Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the notebook build and run in binder? #181

Closed
Tracked by #172
ricardobarroslourenco opened this issue Jun 26, 2023 · 4 comments
Closed
Tracked by #172

Does the notebook build and run in binder? #181

ricardobarroslourenco opened this issue Jun 26, 2023 · 4 comments

Comments

@ricardobarroslourenco
Copy link
Collaborator

No description provided.

@acocac
Copy link
Member

acocac commented Jun 27, 2023

It seems the documentation or guidelines for reviewers are still confusing. Can you confirm it @ricardobarroslourenco? You should crossreference specific issues in the notebook repository instead of EDS book one.

@ricardobarroslourenco
Copy link
Collaborator Author

@acocac I think that I may have got confused. While doing the checklist in the review, it does have a button that opens an issue for every item (I understood that it was supposed to click it for the items that needed review - which also kept a link to the main review process).

@acocac
Copy link
Member

acocac commented Jun 29, 2023

@acocac I think that I may have got confused. While doing the checklist in the review, it does have a button that opens an issue for every item (I understood that it was supposed to click it for the items that needed review - which also kept a link to the main review process).

Hi, thanks for reporting it! This is a new functionality in GitHub that I wasn't familiar with. I'll update the guidelines and see how we can maximize the functionality.

@acocac
Copy link
Member

acocac commented Jun 29, 2023

Closing this issue. We'll consider to update EDS book guidelines with the GitHub functionality of checklists.

@acocac acocac closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants