-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add facility to quickly define a linear transformers-predictor pipeline #75
Comments
I think this is great, but would imitate a flaw of the vanilla sklearn design: you don't specify which variables/covariates the transformer ought to be applied to. Makes sense to apply it in default to "all applicable" (e.g., one-hot to all categorical), but that's not always what one wants (e.g., PCA only to the variables coming from the questionnaire etc). Potential solution is to specify pairs, transformer & variable names? |
Good point! However, making a column-selective transformer is, in my view, just a different kind of learning network, for which we could have another macro (or composite model type). So, e.g., you would do:
|
But would that not kill all other features entirely rather than just apply PCA only to these? |
No, no. The incoming data into two, applies PCA to one part, then reassembles. Maybe "restrict" is a bad name. Perhaps "selective" is better. I am not going into the implementation here. |
Ah, makes sense. There's at least one of the two issues, depending on the design: Your comment indicates that you favour (b)? Or, do you have an idea which altogether avoids the issues? E.g., a default convention for output variables? |
Implemented some time ago. Query |
I think a macro is the easiest way to do this, given the existing learning networks API. Syntax would look something like:
The things on the right are models and the result
composite_model
is just another model whose hyper parameters are called "transformer1", "transformer2", "predictor" and the (mutable) values of these are set to totransformer1
,transformer2
,predictor
. Mutating these would mutatecomposite_model
.The text was updated successfully, but these errors were encountered: