Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate a classifier Capabilities summary #997 #1229

Merged

Conversation

BINAYKUMAR943
Copy link
Contributor

@BINAYKUMAR943 BINAYKUMAR943 commented Jul 30, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR automatically generates a summary of the capabilities of the different classifiers. Some classifiers such as ProximityStump, ProximityTree etc. doesn't have any capabilities defined in their class. The code is currently putting N/A for them, but it will be included in the table once it gets added.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Please review the part which is automatically generating the capabilities of the classifier. If it seems fine then we can generate a list like this for all the estimators. Code is just putting N/A in the table to the capabilities for the classifiers that do not have any capabilities defined.

Any other comments?

Please review and approve it. @TonyBagnall @ABostrom

PR checklist

For all contributions
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@BINAYKUMAR943 BINAYKUMAR943 changed the title Create classifier_capabilities_table.py Auto-generate a classifier Capabilities summary #997 Jul 30, 2021
@TonyBagnall TonyBagnall added the module:classification classification module: time series classification label Jul 30, 2021
@TonyBagnall
Copy link
Contributor

hi, there are I'm afraid strict formatting rules for submissions which you code failed the test for. Read here https://github.com/alan-turing-institute/sktime/blob/main/CONTRIBUTING.md

@TonyBagnall
Copy link
Contributor

click on "details" next to the code quality and it will tell you why it failed. If you are on a command line you can use the pre-commit tool to check if it passes beforehand

@TonyBagnall
Copy link
Contributor

if you are on a command line you can check beforehand with pre-commit, although I cannot get this working with github desktop
image

@BINAYKUMAR943
Copy link
Contributor Author

if you are on a command line you can check beforehand with pre-commit, although I cannot get this working with github desktop
image

I have made some changes to the code and followed the suggested steps.

@BINAYKUMAR943
Copy link
Contributor Author

click on "details" next to the code quality and it will tell you why it failed. If you are on a command line you can use the pre-commit tool to check if it passes beforehand
Thank you a ton for the suggestion. I have made some changes and checked using the pre-commit tool in my locals. It is passing now.

@TonyBagnall TonyBagnall self-assigned this Aug 12, 2021
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put this in as its in contrib, we can refactor it for tags later

@BINAYKUMAR943
Copy link
Contributor Author

I'll put this in as its in contrib, we can refactor it for tags later

Sure, Thanks!

@TonyBagnall TonyBagnall merged commit 5a2c1e1 into sktime:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants