Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update classification.py #1525

Merged
merged 16 commits into from Oct 20, 2021
Merged

Update classification.py #1525

merged 16 commits into from Oct 20, 2021

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Oct 15, 2021 •
edited

very minor changes to the classifier template to reflect changes to the base class

add optional override of correct tags
add optional _predict_proba
also
changed the name to MyTimeSeriesClassifier

@TonyBagnall TonyBagnall added the module:classification classification module: time series classification label Oct 15, 2021
@TonyBagnall TonyBagnall marked this pull request as ready for review October 19, 2021 13:51
chrisholder
chrisholder previously approved these changes Oct 20, 2021
View reviewed changes
Tony Bagnall added 2 commits October 20, 2021 12:31
Merge branch 'main' into classifier_template
dbbb9d0
matt changes
157bc7c 
add multithread, add skeleton for _predict_proba, change the type hint for predict proba
MatthewMiddlehurst
MatthewMiddlehurst approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included these comments for _predict proba so its the same as _predict:

# implement here
# IMPORTANT: avoid side effects to X

@TonyBagnall TonyBagnall merged commit 3a3b009 into main Oct 20, 2021
@TonyBagnall TonyBagnall deleted the classifier_template branch October 20, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisholder chrisholder chrisholder approved these changes

@MatthewMiddlehurst MatthewMiddlehurst MatthewMiddlehurst approved these changes

@mloning mloning Awaiting requested review from mloning

Assignees
No one assigned
Labels
module:classification classification module: time series classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TonyBagnall @chrisholder @MatthewMiddlehurst