Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added meta-tuning example to docstring of ForecastingGridSearchCV #1656

Merged
merged 9 commits into from Dec 5, 2021
Merged

Added meta-tuning example to docstring of ForecastingGridSearchCV #1656

merged 9 commits into from Dec 5, 2021

Conversation

aiwalter
Copy link
Contributor

What does this implement/fix? Explain your changes.

Added meta-tuning example to docstring

@aiwalter aiwalter added documentation Documentation & tutorials module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting labels Nov 27, 2021
@aiwalter aiwalter marked this pull request as ready for review November 27, 2021 17:25
fkiraly
fkiraly requested changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh, looks like the return is not what is expected. Fix that, I guess?

Might also be worth passing a smaller fh, or the printout gets too big.

@aiwalter
Copy link
Contributor Author

yes, I made a smaller fh and I forgot the (...) in the output placeholder

fkiraly
fkiraly approved these changes Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks right now, thanks.

@fkiraly fkiraly merged commit f09696c into sktime:main Dec 5, 2021
@aiwalter aiwalter deleted the meta_grid_search branch December 5, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@mloning mloning Awaiting requested review from mloning

@RNKuhns RNKuhns Awaiting requested review from RNKuhns

@SveaMeyer13 SveaMeyer13 Awaiting requested review from SveaMeyer13

Assignees
No one assigned
Labels
documentation Documentation & tutorials module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aiwalter @fkiraly