[ENH] fix get_window utility when window_length was None
#2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:datatypes
khrapovs
suggested changes
Jun 26, 2022
|
Good catch! No bugfix without tests that nail the correct behaviour down, optimally. Done. |
khrapovs
approved these changes
Jun 27, 2022
fkiraly
added a commit
that referenced
this pull request
Jul 5, 2022
…ecasters (#2865) This series of PR introduces auto-vectorization over columns for univariate estimators, i.e., the estimator is applied by column. Applies to forecasters and transformers. The `forecasters_` and `transformers_` attribute, in this case, is a `pd.DataFrame` which has columns corresponding to the columns vectorized over. This replaces previous behaviour where, instead, an error would be raised. This PR is part 1 of a series of two PRs, one for forecasters and transformers, for easier review. This PR contains vectorization for forecasters. Part 2, transformers, is in #2867. The PR relies on: * PR #2864 which introduces column (variable) vectorization to `VectorizedDF`. * PR #2866 as `get_window` had a bug and the new tests were trying to use it. * PR #2870 since the cutoff was not properly updated in the vectorized case
fkiraly
added a commit
that referenced
this pull request
Jul 5, 2022
…nsformers (#2867) This series of PR introduces auto-vectorization over columns for univariate estimators, i.e., the estimator is applied by column. Applies to forecasters and transformers. The `forecasters_` and `transformers_` attribute, in this case, is a `pd.DataFrame` which has columns corresponding to the columns vectorized over. This replaces previous behaviour where, instead, an error would be raised. This PR is part 2 of a series of two PRs, one for forecasters and transformers, for easier review. This PR contains vectorization for transformers. Part 1, forecasters, is in #2865. The PR relies on: * Part 1, #2865 * PR #2864 which introduces column (variable) vectorization to `VectorizedDF`. * PR #2866 as `get_window` had a bug and the new tests were trying to use it. * PR #2870 since the cutoff was not properly updated in the vectorized case
fkiraly
added a commit
that referenced
this pull request
Jul 6, 2022
…nsformers (#2937) This series of PR introduces auto-vectorization over columns for univariate estimators, i.e., the estimator is applied by column. Applies to forecasters and transformers. The `forecasters_` and `transformers_` attribute, in this case, is a `pd.DataFrame` which has columns corresponding to the columns vectorized over. This replaces previous behaviour where, instead, an error would be raised. This PR is part 2 of a series of two PRs, one for forecasters and transformers, for easier review. This PR contains vectorization for transformers. Part 1, transformers, is in #2865. The PR relies on: * PR #2865 * PR #2864 which introduces column (variable) vectorization to `VectorizedDF`. * PR #2866 as `get_window` had a bug and the new tests were trying to use it. * PR #2870 since the cutoff was not properly updated in the vectorized case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_windowutility was broken whenwindow_lengthwasNone, it would return the objectobjunchanged.This has now been fixed.
In addition, the
lagdefault has been set to zero, which is interpreted as a zero integer ortimedelta, depending onobj.Test cases for
Noneinput behaviour have been added.