[BUG] fix forecaster default predict_quantiles
for multivariate data
#3106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported by @lbventura in #3105: the default implementation of
_predict_quantiles
, when_predict_interval
is implemented, would return quantiles only for the first variable - which is fine in univariate forecasting, but produces too few columns in multivariate forecasting.This has now been fixed, the correct columns are now returned in both cases, under the condition that
_predict_quantiles
is implemented but_predict_interval
is not.Odd that this was not tested so far, I still need to investigate why.
To the bets of my knowledge, we should be testing the proba predict methods with multivariate scenarios?