Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix AutoEnsembleForecaster inverse variance bug #3208

Merged
merged 3 commits into from Aug 7, 2022

Conversation

AnH0ang
Copy link
Contributor

@AnH0ang AnH0ang commented Aug 7, 2022

Reference Issues/PRs

Fixes #3199

What does this implement/fix? Explain your changes.

Fix the error described in #3199 that occurred in AutoEnsembleForecaster when method="inverse-variance" was used. This was caused by passing X instead of X_test to the internal forecasters when making predictions in fit method. This has been fixed. In addition, tests for the AutoEnsembleForecaster have been added.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works! Thanks, @AnH0ang!

@fkiraly fkiraly added the module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting label Aug 7, 2022
@fkiraly fkiraly merged commit 6cb1404 into sktime:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error in inverse-variance method of AutoEnsembleForecaster
2 participants