Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]Updated load_data.py #496

Merged
merged 2 commits into from Nov 26, 2020
Merged

[Doc]Updated load_data.py #496

merged 2 commits into from Nov 26, 2020

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Nov 17, 2020 •
edited

Reference Issues/PRs

Fixes #484

What does this implement/fix? Explain your changes.

Added required docstrings.

Does your contribution introduce a new dependency? If yes, which one?

No

PR checklist

  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • I've added the docstrings to the file.
  • I've updated the existing file.

mloning
mloning approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Afzal-Ind, looks all good to me, I'll merge it in the next few days!

@mloning
Copy link
Contributor

mloning commented Nov 24, 2020

Hi @Afzal-Ind, sorry for the delay, we had some CI issues, but they're all fixed now. So the PR should be good to go once all tests pass!

@afzal442
Copy link
Contributor Author

afzal442 commented Nov 24, 2020 •
edited

sorry for the delay, we had some CI issues, but they're all fixed now.

It's Alright then...

@mloning
Copy link
Contributor

mloning commented Nov 26, 2020

Thanks again @Afzal-Ind

@mloning mloning merged commit 5a9b90c into sktime:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloning mloning mloning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Fill in missing docstrings
2 participants
@afzal442 @mloning