Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate (example and fix) #690

Merged
merged 19 commits into from Feb 25, 2021
Merged

Evaluate (example and fix) #690

merged 19 commits into from Feb 25, 2021

Conversation

aiwalter
Copy link
Contributor

Reference Issues/PRs

#657 #622

What does this implement/fix? Explain your changes.

Added example in notebook. Fix minor tqdm issue.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloning
Copy link
Contributor

mloning commented Feb 18, 2021

Thanks @aiwalter - the n_split fix is related to #632 - probably best to fix this in the CV class.

@aiwalter
Copy link
Contributor Author

from my side, this can be merged

@mloning
Copy link
Contributor

mloning commented Feb 22, 2021

How do we handle the tqdm dependency now?

@aiwalter
Copy link
Contributor Author

I have removed it, no?

@aiwalter
Copy link
Contributor Author

Sry seems I didnt push 🙄

@aiwalter
Copy link
Contributor Author

should be fine now :) sry for confusion

Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now! Thanks @aiwalter, will merge tomorrow

@mloning mloning merged commit 9a9b732 into sktime:master Feb 25, 2021
@aiwalter aiwalter deleted the evaluate branch February 25, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants