Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: auto generate a Figure List #2834

Open
da5nsy opened this issue Nov 17, 2022 · 6 comments
Open

Proposal: auto generate a Figure List #2834

da5nsy opened this issue Nov 17, 2022 · 6 comments
Labels
idea-for-discussion This can be used for inviting discussion from collaborators or community in general infrastructure For all issues related to book infrastructure

Comments

@da5nsy
Copy link
Collaborator

da5nsy commented Nov 17, 2022

Edit: the previous, manually maintained and the eventually outdated list has been deleted, this issue is now a placeholder that we may want to have a list of figures, that is auto-generated.

======

https://github.com/alan-turing-institute/the-turing-way/blob/main/book/website/figures/_figure-list.md


I argue that instead of updating it, we remove it, since I am not convinced of its utility.

@da5nsy da5nsy added idea-for-discussion This can be used for inviting discussion from collaborators or community in general infrastructure For all issues related to book infrastructure labels Nov 17, 2022
@da5nsy
Copy link
Collaborator Author

da5nsy commented Nov 17, 2022

This is blocking #2838.

@da5nsy
Copy link
Collaborator Author

da5nsy commented Nov 17, 2022

Deleted in #2857, for #2838, but will leave this issue open, for further discussion.
See also: discussion on #2857

@bsipocz bsipocz changed the title Proposal: delete figure_list.md Proposal: auto generate a Figure List Nov 17, 2022
@aleesteele aleesteele added this to To discuss (pro and con) in Infrastructure Mar 30, 2023
@bsipocz
Copy link
Member

bsipocz commented Mar 31, 2023

I expect there are a few technical solutions for this, if not, then the new mpl indexing project may also help: https://github.com/matplotlib/matplotlib/wiki/Google-Season-of-Docs-2023:-Proposal

@da5nsy
Copy link
Collaborator Author

da5nsy commented Apr 7, 2023

@JimMadge
Copy link
Member

What is it we want to get out of this? Do we just want a page with a table/list of all images in the repository (which isn't quite the same as all of the images in the book)?

Thinking about the style guide positions on alt text and captions, if we did have a list, it could be some sort of structured data including alt text and captions. Could we make a directive to create a figure using that information? It might save duplication of that kind of information and make it easier to ensure all images have alt text and a caption.

Despite guidance indicating that all figures should be added to figure_list.md, that file is only infrequently updated.

I don't think that is surprising. It might be easy to miss the guidance and the book will still build if you ignore it.

Making the process,

  1. Add image
  2. Edit this yaml file
  3. Use the turing-way-figure directive

might enforce good practice at the cost of making contributing less straightforward.

(Plus it would be a lot of work to add all this information for existing figures 😱)

@da5nsy
Copy link
Collaborator Author

da5nsy commented May 22, 2023

Linking #2046 because I think they solve similar problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea-for-discussion This can be used for inviting discussion from collaborators or community in general infrastructure For all issues related to book infrastructure
Projects
Infrastructure
To discuss (pro and con)
Status: To discuss (pro and con)
Development

No branches or pull requests

3 participants