Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve research compendia Chapter : Fixed Broken Links #1077

Merged
merged 3 commits into from
May 14, 2020

Conversation

growupboron
Copy link
Contributor

@growupboron growupboron commented May 12, 2020

Fixed the link error of Reproducible Environments, Binder Hub, Reproducibility with Make in the Prerequisites / Recommended skill level of Research Compendia.

Link for subsections does not work as I expected. See screenshot from https://the-turing-way.netlify.com/research_compendia/research_compendia.html

Fixes #1003 & #1004

What should a reviewer concentrate their feedback on?

  • Everything looks ok?

@netlify
Copy link

netlify bot commented May 12, 2020

Deploy preview for the-turing-way ready!

Built with commit 02f0c46

https://deploy-preview-1077--the-turing-way.netlify.app

@growupboron growupboron changed the title [WIP] Improve research compendia Chapter [WIP] Improve research compendia Chapter : Fixed Broken Links May 12, 2020
@HeidiSeibold
Copy link
Collaborator

HeidiSeibold commented May 12, 2020

Thanks for the PR! 👏

As link fixing experts, could you also take a look at the end of section "How this will help you/why this is useful" (it is mentioned in #1003 )? That would be amazing 🎉

@growupboron growupboron reopened this May 12, 2020
@growupboron
Copy link
Contributor Author

growupboron commented May 12, 2020

Sorry for the commit clutter, cleaned excess commits (self-experimentals) to apply for Pull Request with a single commit.

Fixed Broken Links
@growupboron
Copy link
Contributor Author

growupboron commented May 12, 2020

Thanks for the PR! clap

As link fixing experts, could you also take a look at the end of section "How this will help you/why this is useful" (it is mentioned in #1003 )? That would be amazing tada

@HeidiSeibold fixed it. I hope, this does it.

@malvikasharan
Copy link
Collaborator

@all-contributors please add @growupboron for bug fix.

@allcontributors
Copy link
Contributor

@malvikasharan

I've put up a pull request to add @growupboron! 🎉

@malvikasharan
Copy link
Collaborator

@HeidiSeibold I will leave the review up to you for this. Let me know if you would need a second opinion on that.

@malvikasharan malvikasharan changed the title [WIP] Improve research compendia Chapter : Fixed Broken Links Improve research compendia Chapter : Fixed Broken Links May 13, 2020
@HeidiSeibold
Copy link
Collaborator

Thanks @malvikasharan

Somehow I still see the broken link when I click on deploy/netlify -> Details

Screenshot:
image

🤔 wondering if this is because the preview does not work or because the fix doesn't really fix it.
Unfortunately I cannot render it locally at them moment so I depend on the preview 😬

Copy link
Collaborator

@malvikasharan malvikasharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeidiSeibold the link to the section was missing.

@HeidiSeibold
Copy link
Collaborator

Lol, ok, thanks. 🤣

Copy link
Collaborator

@HeidiSeibold HeidiSeibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all great to me 🎉

Thanks for the PR! 🌻

@HeidiSeibold HeidiSeibold merged commit 5631209 into the-turing-way:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants