-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve research compendia Chapter : Fixed Broken Links #1077
Conversation
Deploy preview for the-turing-way ready! Built with commit 02f0c46 |
Thanks for the PR! 👏 As link fixing experts, could you also take a look at the end of section "How this will help you/why this is useful" (it is mentioned in #1003 )? That would be amazing 🎉 |
Updated Link the-turing-way#1004
Sorry for the commit clutter, cleaned excess commits (self-experimentals) to apply for Pull Request with a single commit. |
Fixed Broken Links
@HeidiSeibold fixed it. I hope, this does it. |
@all-contributors please add @growupboron for bug fix. |
I've put up a pull request to add @growupboron! 🎉 |
@HeidiSeibold I will leave the review up to you for this. Let me know if you would need a second opinion on that. |
Thanks @malvikasharan Somehow I still see the broken link when I click on 🤔 wondering if this is because the preview does not work or because the fix doesn't really fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeidiSeibold the link to the section was missing.
Lol, ok, thanks. 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all great to me 🎉
Thanks for the PR! 🌻
Fixed the link error of
Reproducible Environments
,Binder Hub
,Reproducibility with Make
in the Prerequisites / Recommended skill level of Research Compendia.Fixes #1003 & #1004
What should a reviewer concentrate their feedback on?