Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Zero to binder in R #1139

Merged
merged 10 commits into from May 28, 2020
Merged

[WIP] Zero to binder in R #1139

merged 10 commits into from May 28, 2020

Conversation

annakrystalli
Copy link
Collaborator

Summary

Translates the Zero to Binder materials for R Users

List of changes proposed in this PR (pull-request)

  • Straight copy of the materials, edited with R code

What should a reviewer concentrate their feedback on?

  • I'll be adding short demos of holepunch functions for performing the same using R locally. Feel free to remove if you think they are distracting. I'll add those changes as the last commit so that can easily be rolled back if required.

Acknowledging contributors

@netlify
Copy link

netlify bot commented May 23, 2020

Deploy preview for the-turing-way ready!

Built with commit 4c24421

https://deploy-preview-1139--the-turing-way.netlify.app

@annakrystalli
Copy link
Collaborator Author

Hello @sgibson91! Finally managed to finish this. Got distracted by cross-stitching! 😜

Might be a good idea to try and run the r version yourself to ensure it all checks out and makes sense! 😄

@sgibson91
Copy link
Member

THANK YOU SO MUCH FOR THIS! 💖 and cross-stitching is a 100% approved distraction 😉

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fab @annakrystalli, THANK YOU! 🎉:sparkling_heart: I don't think your notes about holepunch break the flow at all. I've left some comments that are mostly just formatting/typos and will probably need updating in the python version too. Also, did you mean to commit the-turing-way.Rproj file? From the edit to the .gitignore, it looks like it might be there by accident?

@sgibson91
Copy link
Member

@all-contributors please add @annakrystalli for tutorial

@allcontributors
Copy link
Contributor

@sgibson91

I've put up a pull request to add @annakrystalli! 🎉

annakrystalli and others added 5 commits May 27, 2020 19:35
…ntations/zero-to-binder-r.md

Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
…ntations/zero-to-binder-r.md

Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
…ntations/zero-to-binder-r.md

Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
…ntations/zero-to-binder-r.md

Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
…ntations/zero-to-binder-r.md

Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
@annakrystalli
Copy link
Collaborator Author

Good to go! 🙌 🚀

Thanks for 👀 through @sgibson91

@sgibson91 sgibson91 merged commit 1088a43 into master May 28, 2020
@annakrystalli annakrystalli deleted the AK-zero-to-binder-r branch May 28, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants