Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a chapter on Book Dash (for the community handbook) #1262

Merged
merged 38 commits into from
Aug 24, 2020

Conversation

malvikasharan
Copy link
Collaborator

@malvikasharan malvikasharan commented Jul 13, 2020

Summary

Fixes #848

  • This PR creates a new chapter with multiple subchapters on The Turing Way Book Dash

List of changes proposed in this PR (pull-request)

  • Create a landing page for the chapter
  • 3 subchapters: 1) application and review, 2) selection and preparation, 3) main events
  • 4 templates: 1) issue checklist for preparation, 2) pre-event call's template, 3) main event notes template, 4) feedback template

What should a reviewer concentrate their feedback on?

  • Captures all details
  • Includes all the references
  • Reviewers can ignore template review to avoid overburdening themselves
  • Everything looks ok?

Acknowledging contributors

@netlify
Copy link

netlify bot commented Jul 13, 2020

Deploy preview for the-turing-way ready!

Built with commit 95d7c89

https://deploy-preview-1262--the-turing-way.netlify.app

@malvikasharan malvikasharan added the review request Label a PR for urgent request for review, for example to approve a report, abstract, newsletter etc. label Jul 13, 2020
@malvikasharan malvikasharan changed the title Create a chapters on Book Dash (for the community handbook) Create a chapter on Book Dash (for the community handbook) Jul 13, 2020
Copy link
Collaborator Author

@malvikasharan malvikasharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ArielleBL for the review and thoughful comments. I am integrating changes and will work on restructuring based-on two comments (schedule and scorint). 🎉🙌

@malvikasharan
Copy link
Collaborator Author

Integrated suggestions made by @ArielleBL 💃

Copy link
Collaborator

@ArielleBL ArielleBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great chapter! Really comprehensive and clear. Have identified some small typos and one paragraph swap but otherwise this is good to go!

malvikasharan and others added 4 commits August 24, 2020 16:14
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
@malvikasharan
Copy link
Collaborator Author

Thanks @ArielleBL for the reviews. I have integrated the changes and did another round of spellcheck to be sure. Let me know if this could be approved. 🎉

Copy link
Collaborator

@ArielleBL ArielleBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray looks all good to go to me @malvikasharan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-handbook PR: merged review request Label a PR for urgent request for review, for example to approve a report, abstract, newsletter etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants