-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a chapter on Book Dash (for the community handbook) #1262
Conversation
Deploy preview for the-turing-way ready! Built with commit 95d7c89 |
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ArielleBL for the review and thoughful comments. I am integrating changes and will work on restructuring based-on two comments (schedule and scorint). 🎉🙌
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
Integrated suggestions made by @ArielleBL 💃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great chapter! Really comprehensive and clear. Have identified some small typos and one paragraph swap but otherwise this is good to go!
book/website/community-handbook/bookdash/bookdash-preparation.md
Outdated
Show resolved
Hide resolved
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
Co-authored-by: ArielleBL <47155465+ArielleBL@users.noreply.github.com>
book/website/community-handbook/bookdash/bookdash-application.md
Outdated
Show resolved
Hide resolved
Thanks @ArielleBL for the reviews. I have integrated the changes and did another round of spellcheck to be sure. Let me know if this could be approved. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray looks all good to go to me @malvikasharan
Summary
Fixes #848
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors