Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subchapters in the leadership #1553

Closed
wants to merge 4 commits into from
Closed

Adding subchapters in the leadership #1553

wants to merge 4 commits into from

Conversation

malvikasharan
Copy link
Collaborator

@malvikasharan malvikasharan commented Nov 10, 2020

Summary

Fixes #1224

  • Adding subchapter in the Leadership chapter

List of changes proposed in this PR (pull-request)

What should a reviewer concentrate their feedback on?

  • A landing page
  • Following subchapter
    • file: collaboration/leadership
    • file: collaboration/leadership/leadership-features
    • file: collaboration/leadership/leadership-building
    • file: collaboration/leadership/leadership-structure
    • file: collaboration/leadership/leadership-diversity
    • file: collaboration/leadership/leadership-opportunities
    • file: collaboration/leadership/leadership-avoid
    • file: collaboration/leadership/leadership-stories

Acknowledging contributors

@netlify
Copy link

netlify bot commented Nov 10, 2020

Deploy Preview for the-turing-way failed.

Name Link
🔨 Latest commit 85f894d
🔍 Latest deploy log https://app.netlify.com/sites/the-turing-way/deploys/646f44b0dd55aa0008c5ec4c

@malvikasharan malvikasharan added the book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 label Nov 10, 2020
@lauracion
Copy link
Collaborator

Today I fixed tiny problems, so the chapter in this branch renders.

The Figure in leadership.md is not rendering correctly and I still need to figure out why.

I need to continue fine-tuning leadership-building.md next.

@lauracion
Copy link
Collaborator

lauracion commented Feb 3, 2021

Next time I have a chance at working on this I need to:

  • figure out what is the problem in the alt text for the figure in leadership-building.md
  • find a good place to talk about benevolent dictator for life in this chapter and how it does not align well with most of what open and healthy leadership entails
  • check if the figure in leadership.md now has the right path
  • continue editing leadership-structure.md

@bsipocz
Copy link
Member

bsipocz commented May 17, 2021

find a good place to talk about benevolent dictator for life in this chapter and how it does not align well with most of what open and healthy leadership entails

What about having a section with "other leadership models" with the long description of "prevalent, exclusive practices in open source /data science communities". In addition to BDFL it could include self-appointed committees with fixed membership clinging to power, basically acting as BDFL. And maybe also the "lab run" open source/data science project might also fit, e.g. when one has to be affiliated with an institute to be part of the project (the approach is all legit of course, but not as a way to lead an inclusive project).

@lauracion
Copy link
Collaborator

That would be great, Brigitta!
If you would like to work on adding this section, please go ahead! Happy to be one of its reviewers later on.
Also, if you have suggestions to improve the current chapter, please go ahead 😄

@bsipocz
Copy link
Member

bsipocz commented May 17, 2021

For review, would you prefer an inline review on the PR or comments on the draft hackmd?

I can start adding a skeleton for the section and drafting it out.

@lauracion
Copy link
Collaborator

Great!
Inline review on the PR is best. The hackmd draft is no longer up to date.
Thank you, Brigitta!

@malvikasharan
Copy link
Collaborator Author

@pherterich I have updated this branch here. Let me know if you face any error editing files in this chapter.

@malvikasharan
Copy link
Collaborator Author

I have created a placeholder for the notes @aleesteele took at yesterday's discussion led by Patricia, and maybe a place to also add notes from March's Fireside discussion: Emergent Roles in Research Infrastructure & Technology | Noor, Esther, Borhane, Beth, Arielle | Video | Etherpad: https://pad.sfconservancy.org/p/ttw-fireside-chat-mar2022

@SaraVilla
Copy link
Collaborator

Some thoughts/doubts/input suggestions about the 'What to avoid in leadership' subchapter:

  • Personalism: not sure I understand this concept, what do you mean by it? not much to add so far...
  • Elitism: Leadership and research in general benefits a lot from inclusivity and diversity. Thus, being a elitist leader won't be efficient for any project neither for the leaders themselves. The more open and different, the better
  • Ignore the personal side of the team: members of the team/organisation can disclose or not as much as they want from their personal lives. But it is up to the leader to worry and keep an eye on them in order to encourage understanding, community help, help seeking and avoid burnout. If leaders don't' ask, team member most likely (and even more newer member of the team), won't ask for help. This will likely have an impact in the overall project/team/organisation.
  • Tunnel vision: leaders should be aware of the outside-organisation problems/alternatives/options... Even if the organisation is focus on one line of work, awareness about what is 'going on around' will prompt further discussions and go beyond finding quick solutions.
  • Hide weaknesses: weaknesses should be something to embrace and work on, not something to hide. When accepting what a person/team is missing, there is more chances of successful solutions (if needed; sometimes a weakness is not an error or mistake that needs to be solved)

@malvikasharan malvikasharan temporarily deployed to compress-images May 24, 2023 15:54 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

  • book/website/figures/HealthyLeadership.jpg
  • book/website/figures/leadership-wordcloud.jpg
  • book/website/figures/leadership-wordcloud.png

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 10:35 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
book/website/figures/decolonising-knowledge.jpg 611.98 KB 95.84 KB 84%
Total: 6.74 MB 1.74 MB 69%

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 10:37 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
Total: 6.13 MB 1.64 MB 68%

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 10:38 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
Total: 6.13 MB 1.64 MB 68%

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 10:45 — with GitHub Actions Inactive
@JimMadge
Copy link
Member

Quite a merge conflict 😄.

Is this because of images being compressed?

@bsipocz I've never been great at this kind of merge, where you are asked about 'LOCAL' and 'REMOTE'. I suppose the answer here is to always choose 'REMOTE'?

When you do that, there are still problems with paths to images which don't exist and some WARNING: image file not readable:. I think it will still require some manual work to reintroduce deleted images or update paths.

@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
Total: 6.13 MB 1.64 MB 68%

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 10:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
Total: 6.13 MB 1.64 MB 68%

Plan: Free
Usage: 0 bytes of 25.00 MB

@BatoolMM
Copy link
Member

BatoolMM commented May 25, 2023

Quite a merge conflict 😄.

Is this because of images being compressed?

@bsipocz I've never been great at this kind of merge, where you are asked about 'LOCAL' and 'REMOTE'. I suppose the answer here is to always choose 'REMOTE'?

When you do that, there are still problems with paths to images which don't exist and some WARNING: image file not readable:. I think it will still require some manual work to reintroduce deleted images or update paths.

Hey @JimMadge, sorry for jumping in like this! I was just having a chat with Mavika in the chat, and it looks like fixing the conflicts with the images might require quite a bit of work. However, Mavika mentioned (correct me if I'm wrong, Mavika) that she doesn't mind losing the commit history by simply copying and pasting the files (including the images) for the leadership chapter, images, references, and table of contents. As far as I understand, the changes in the workshops folder are unrelated to this PR.

So, what do you think? Would you recommend creating a new branch and new PR (with copy/pasting) the files? Or do you think it would be easier to just tackle the image conflicts? Feel free to tackle it either ways (Malvika correct me I am wrong)!

@JimMadge
Copy link
Member

JimMadge commented May 25, 2023

@BatoolMM yes, sometimes getting your workspace correct, stage, commit and let git worry about the diff is an easier way to get the same product. I think that is legitimate. It is a shame to loose the individual commits and authors. Luckily we have other ways to recognise the contributors 👍.

We shouldn't let some git workflow orthodoxy prevent good contributions to the book.

@malvikasharan malvikasharan temporarily deployed to compress-images May 25, 2023 11:20 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Images automagically crushed by Crush.pics

File Before After Savings
book/website/figures/Contributing.jpg 867.45 KB 159.64 KB 82%
book/website/figures/Pandoc.jpg 504.13 KB 107.22 KB 79%
book/website/figures/ai-fairness.jpg 377.14 KB 105.78 KB 72%
book/website/figures/allcontributorsbot-emoji.png 185.06 KB 185.01 KB 0%
book/website/figures/archive-or-publish.jpg 379.54 KB 142.41 KB 62%
book/website/figures/article-types.jpg 389.68 KB 157.34 KB 60%
book/website/figures/binderhub.jpg 676.28 KB 143.41 KB 79%
book/website/figures/collaborative-policy.jpg 450.31 KB 106.47 KB 76%
book/website/figures/community-exchange.jpg 436.96 KB 132.50 KB 70%
book/website/figures/community.jpg 733.03 KB 158.52 KB 78%
book/website/figures/continuous-integration-may19.jpg 639.68 KB 136.25 KB 79%
book/website/figures/culture-shift.jpg 490.52 KB 108.16 KB 78%
Total: 6.13 MB 1.64 MB 68%

Plan: Free
Usage: 0 bytes of 25.00 MB

@malvikasharan
Copy link
Collaborator Author

I am giving up. will create a new branch with the files. Thank you all!

@malvikasharan
Copy link
Collaborator Author

I am seeing the same issue here: #3135

@JimMadge I think you are right that the error is because of the CI for image compression.

@malvikasharan
Copy link
Collaborator Author

Ok, created another one manually on GitHub: #3136

@bsipocz
Copy link
Member

bsipocz commented May 27, 2023

Ok, created another one manually on GitHub: #3136

My week was way busier than I was expecting it, and now that the follow-up PR is merged, is this still relevant?

@malvikasharan
Copy link
Collaborator Author

No worries Brigitta. This PR is not relevant anymore. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text to "Leadership in Data Science"
8 participants