-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate README.md to Arabic #1586
base: main
Are you sure you want to change the base?
Conversation
Deploy preview for the-turing-way failed. Built with commit 419a5c9 https://app.netlify.com/sites/the-turing-way/deploys/605228bd1eef540008be9ada |
right-align doesn't seem to work, needs to be fixed later.
@BatoolMM can you recommend someone to review this? |
Arabic is read from right to left but it's a bit challenging to change the direction of the text in markdown without HTML tags, so it needs to be aligned to the right. Tags `ltr` need to be used for every paragraph or line. It can't be applied to all the text at once.
@WafaaMoh can you help in reviewing the Arabic translation, please? |
@BatoolMM Great work, Batool! |
@Hanaffi, thank you. Actually, this PR is not ready to be merged. I can easily spot many words that may need to be paraphrased. Also, there is sometimes a problem with the orientation of the sentence when English and Arabic are mixed in the same sentence. It'd be great f you can help review it @Hanaffi by making some suggestions, if it's OK? |
@BatoolMM Yes, Thats totally fine. Please add me to the reviewers. |
@BatoolMM |
@Hanaffi, it'll be amazing if this tool works. I think you can work on this PR without assignment by clicking on edit file. It'll be great if you can review it and suggest changes. If you have any question, please let me know! |
@BatoolMM Its disabled for me as I'm not a collaborator 😔😢 |
Malvika kindly gave you triage access. You should be able to use |
What about "review changes" button on the top corner? |
@BatoolMM That just let me write feedback for the pull-request. |
This comment has been minimized.
This comment has been minimized.
Hi @Hanaffi, Batool is right. Most contributors don’t have triage or write access. You should be able to comment on different parts of the document nonetheless. I can definitely give you write access, but I think on any open repository you can review and comment on PRs without being added to the repo. |
@malvikasharan Thanks :) I feel super power now xd |
@BatoolMM Hello Batool, Can you try to fix/pass these checks? |
@BatoolMM
You can view the file better here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pointed out the lines where the orientation is left to right (LTR) when it supposes to be right to left (RTL). Please note that these are mostly English words that were supposed to be on the same line as the Arabic sentences but I separated them into different lines because the order gets changed as I mix English and Arabic in the same sentence. Having said that, the tool you used seems to be really good and it prevents the disorder when English and Arabic are mixed in the same sentence. So, it'll be good if you can move them back to the same sentence as they suppose to be. I find it useful to compare it with the English REAMDME.md
by splitting the screen. It makes it easier to catch the differences. Thank you @Hanaffi
@BatoolMM The problem is that we used div for setting the direction. Do you have any idea on how we can accomplish this? |
When I completed the translation, I encountered the same problem with the |
@BatoolMM It works now :) Notice how Onion podcast is aligned now |
Thank you @Hanaffi. I have used the |
@BatoolMM Unfortunately, I have exams in the next week and I will finish in middle of March. |
@BatoolMM It works on https://stackedit.io/ |
Sorry, @Hanaffi I've just seen your comment. You are doing a good job, you can ignore the orientation and focus on the translation itself. It'll be nice to go through the Arabic translation itself and see if it can be improved. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me now.
@BatoolMM Can you work on the failed checks?
@Hanaffi, thank you for your work. I'll do the rest because it still needs lots of work and I totally understand that this PR is challenging, it shouldn't be approved even if the CI pass. Also, can you not approve or merge any PR unless it's been approved by a core contributor, please? You are very welcome to suggest improvement in this PR if you have the time. |
@BatoolMM Sorry, I have reviewed and approved some PRs as they were already approved by others. |
Summary
In order to attract volunteers to translate chapters of the book to Arabic, I translated
README.md
to Arabic.I think it'll be useful to translate the
CONTRIBUTING.md
and the presentation to Arabic as well.What should a reviewer concentrate their feedback on?
Acknowledging contributors