-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the draft for project design overview #1936
Conversation
✔️ Deploy Preview for the-turing-way ready! 🔨 Explore the source changes: c2aaccc 🔍 Inspect the deploy log: https://app.netlify.com/sites/the-turing-way/deploys/60df19020d518b000782e1c7 😎 Browse the preview: https://deploy-preview-1936--the-turing-way.netlify.app/communication/citable |
@marianaiv Nina offered to review this so I have moved all the materials in this PR. Let me know if the structure looks good to you. |
Adding "Getting Ethical and Legal Approval" to the subchapter on "Planning for Project Design"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya, I've got as far as the repo chapter for now - so much work and writing has gone into this!
Most of the comments I've left are really minor things so I've put them as suggested changes. Hope that's okay!
I've really enjoyed reading it so far - it's great having so many links out to other sections ✨
book/website/project-design/pd-overview/pd-overview-planning.md
Outdated
Show resolved
Hide resolved
book/website/project-design/pd-overview/pd-overview-planning.md
Outdated
Show resolved
Hide resolved
book/website/project-design/pd-overview/pd-overview-planning.md
Outdated
Show resolved
Hide resolved
book/website/project-design/pd-overview/pd-overview-planning.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
Co-authored-by: Nina <44364127+ninadicara@users.noreply.github.com>
@ninadicara Really helpful suggestions and edits. Thank you so much for such thorough and constructive feedback. 🙏 |
@all-contributors please add @ninadicara for review and edits |
I've put up a pull request to add @ninadicara! 🎉 |
@all-contributors please add @marianaiv for content |
I've put up a pull request to add @marianaiv! 🎉 |
This from my side is ready to merge. @marianaiv please go ahead and merge it when you are ready! 🌷 |
Summary
Fixes #1395
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors