Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localisation Guidelines #3153

Merged
merged 4 commits into from Jul 3, 2023
Merged

Update Localisation Guidelines #3153

merged 4 commits into from Jul 3, 2023

Conversation

BatoolMM
Copy link
Member

@BatoolMM BatoolMM commented May 26, 2023

Summary

This PR adds pointers to the localisation guidelines in the README and welcome page, along with updates to certain instructions in the guide.

Fixes #2961

List of changes proposed in this PR (pull-request)

  • Added links to the localization guidelines in the README
  • Added links to the localization guidelines in the welcome page
  • Relocated the localization chapter
  • Updated instructions for our localization co-working meetings

What should a reviewer concentrate their feedback on?

  • Everything looks ok?

Acknowledging contributors

  • All contributors to this pull request are already named in the table of contributors in the README file.

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for the-turing-way ready!

Name Link
🔨 Latest commit ef99bba
🔍 Latest deploy log https://app.netlify.com/sites/the-turing-way/deploys/64a2be5c61785600087d6713
😎 Deploy Preview https://deploy-preview-3153--the-turing-way.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BatoolMM BatoolMM added book-dash-may23 This label is for Book Dash 2023 related issues and PRs translation Translating the book into other languages community-handbook labels May 26, 2023
@BatoolMM
Copy link
Member Author

The CI is failing because of a problem with reference datastudygrouproche2020 which is getting fixed in #3150

@BatoolMM BatoolMM changed the title Update Localization Guidelines Update Localisation Guidelines May 26, 2023
@da5nsy
Copy link
Collaborator

da5nsy commented May 26, 2023

This should now pass CI once the chapter title is updated - #3153 (comment) 😄

book/website/index.md Outdated Show resolved Hide resolved
book/website/index.md Outdated Show resolved Hide resolved
@da5nsy
Copy link
Collaborator

da5nsy commented Jun 6, 2023

Hi @BatoolMM! Is this ready to merge?

@AndreaSanchezTapia
Copy link
Member

Hi @da5nsy I'll review it and let you know when it's done. Thanks!

@BatoolMM
Copy link
Member Author

Thank you @da5nsy and @AndreaSanchezTapia!

Copy link
Collaborator

@melibleq melibleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only made a couple suggestions for the content in book/website/index.md. Checked links in the deployed version to see if they're pointing to the correct pages and it all looks good to me!

book/website/index.md Outdated Show resolved Hide resolved
Co-authored-by: Melissa Black <16723182+melibleq@users.noreply.github.com>
@BatoolMM
Copy link
Member Author

BatoolMM commented Jul 3, 2023

Thank you @melibleq @AndreaSanchezTapia and @da5nsy for the review 🌷
@da5nsy would you mind rebasing the PR if needed and merging it, when you have time, pls?

@da5nsy da5nsy merged commit f071f1e into main Jul 3, 2023
15 checks passed
@da5nsy da5nsy deleted the localisation branch July 3, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-may23 This label is for Book Dash 2023 related issues and PRs community-handbook translation Translating the book into other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants