New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Localisation Guidelines #3153
Conversation
✅ Deploy Preview for the-turing-way ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The CI is failing because of a problem with reference |
book/website/community-handbook/translation/translation-workflow.md
Outdated
Show resolved
Hide resolved
This should now pass CI once the chapter title is updated - #3153 (comment) 😄 |
book/website/community-handbook/translation/translation-workflow.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/translation/translation-workflow.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/translation/translation-workflow.md
Outdated
Show resolved
Hide resolved
book/website/community-handbook/translation/translation-workflow.md
Outdated
Show resolved
Hide resolved
Hi @BatoolMM! Is this ready to merge? |
Hi @da5nsy I'll review it and let you know when it's done. Thanks! |
Thank you @da5nsy and @AndreaSanchezTapia! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only made a couple suggestions for the content in book/website/index.md. Checked links in the deployed version to see if they're pointing to the correct pages and it all looks good to me!
Co-authored-by: Melissa Black <16723182+melibleq@users.noreply.github.com>
Thank you @melibleq @AndreaSanchezTapia and @da5nsy for the review 🌷 |
Summary
This PR adds pointers to the localisation guidelines in the README and welcome page, along with updates to certain instructions in the guide.
Fixes #2961
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors