New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring version control chapter #729
Conversation
Deploy preview for the-turing-way ready! Built with commit 4667a56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so great! Thank you so much @christopherlovell!!
Merge away!! 🚀 👾 🌟
Hi @allcontributors! Please could you add @christopherlovell for infrastructure! |
I've put up a pull request to add @christopherlovell! 🎉 |
This PR currently breaks all the links in this chapter 😬 @KirstieJane and I spoke about the best approach to adding links between sections in chapters when split in to multiple files, and we weren't sure. I've since found the following discussion on the jupyter-book repo: executablebooks/jupyter-book#298 Essentially, it's tricky! If you put in hardcoded links to the markdown, these links break when compiled in to html. You can hard code the links to the |
|
||
As you work on you project you will make more and more commits. | ||
Without any other information it can be hard to remember which version of your project is in which. | ||
Storing past versions is useless if you ca not understand them, and figuring out what they contain by inspecting the code is frustrating and takes valuable time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storing past versions is useless if you ca not understand them, and figuring out what they contain by inspecting the code is frustrating and takes valuable time. | |
Storing past versions is useless if you can not understand them, and figuring out what they contain by inspecting the code is frustrating and takes valuable time. |
Hello @christopherlovell! I'm not part of the Turing Way but I did participate on one of the collaboration cafes last month and chatted with @KirstieJane about the I'd like to add as an outsider that it might make sense to walk people through a little more global config setup, particularly handling the I'm happy to open a PR to your fork to add those changes if you think they're worth discussing further. |
Hi @jbteves, thanks for taking a look! This PR was just for restructuring the files so that the content was not just in one single enormous file / page. I didn't have any involvement in editing the content, perhaps you could raise a PR for that separately? Not sure if this PR is still relevant as I imagine there has been a lot of work on the content that these changes would significantly break. Probably worth closing this and attempting again.... |
These changes have been integrated into the current version of the book. Thank you all for your contribution. |
Summary
Addresses (but does not close) #468.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors
Thanks!