-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save screenshots of each site's final state #2
Comments
The predictable location could be /screenshots/{date}/{pluginName}.png |
Proposed solution from @cettox in #8. |
Here are the things I'd like to consider:
|
Here's what I'm thinking for now. Screenshots will be off by default. If a user wants to enable them, they can do so in their
Or, if the user always wanted screenshots enabled, they could update their config like this:
Screenshots would be written out as PNGs after every step (every time a dot is printed to the console) and after errors occur. The naming convention would be like this:
Old screenshots would be overwritten on every write. So, for a GitHub password update, the generated files would look like this:
This gives the user the chance to check and see what went wrong, and at which step. @coalman, curious what your thoughts are on it! Does this make sense? |
I think this is perfect for screenshots. However, I think it would be nice to have text-based log files too (incase I lose the output and I can't seem to replicate the error), but for the screenshot issue I think this is perfect. |
Maybe every session that experiences an error should get it's own folder (for screenshots and a central log file to go in)? I guess a log file isn't completely necessary. Might be overkill. |
@coalman I think I could get behind the idea of a new directory for each session of screenshots. At first I was concerned this would bloat up disk usage, but then remembered that this isn't a script that runs daily, but probably every several months. That seems reasonable to have timestamped directories for each run. Maybe there's some type of string interpolation we allow for configuration, and the default could be A basic log file might be worth it. Just a timestamped list of update successes and failure messages. I could see how that would be valuable. If after a month, I forgot that one password update had failed and tried to log in, it might be helpful to check back and see that the adapter was broken or something had gone wrong. |
I like the idea of allowing the user to configure the string interpolation. The only problem I see with that default format is if two of them are started in the same second (not sure why anyone would do this though). I think using timestamped directories with a log file could be worth while. |
@coalman You know, maybe the simpler approach is just to have the default be |
Here's a nice technique for extending |
Yeah, I think that's the approach to use. Where would the logs go? I couldn't find a good way to resolve the user's home directory with casperjs. Edit: I guess we could make it relative to the manifest path passed to init.js |
Each site should capture a screenshot after it's updated (or has an error) and the screenshots should be in a standard location on the system.
The text was updated successfully, but these errors were encountered: