Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub directory not using submodule #322

Open
1 task
NoPlanNomad opened this issue Jan 24, 2023 · 1 comment
Open
1 task

sub directory not using submodule #322

NoPlanNomad opened this issue Jan 24, 2023 · 1 comment

Comments

@NoPlanNomad
Copy link

NoPlanNomad commented Jan 24, 2023

Feature category

  • enhancement - documentation

The problem
the cmake sub directory documentation tells developers to clone the subject.
but might be better to advice them to use a git submodule

The solution I'd like
advice to use git submodule with the following command
git submodule add https://github.com/alandefreitas/matplotplusplus/ <submodule directory location>

@alandefreitas
Copy link
Owner

but might be better to advice them to use a git submodule

I don't think there's much consensus on that at this point.

The best advice could be to not do that at all or describe the requirements properly in a package manager manifest format. But then we miss this form of integration some people might want or end up with conflicts between package managers.

I think the best and smallest improvement on top of that would be FetchContent, which is already supported and documented. But I think the point of that example is to show that add_subdirectory works, regardless of how the directory got there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants