fix: use GPS coordinates for users in China #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you'll be helping to maintain, please start using conventional commit messages. Also, please make sure you always start branches from dev. Given we need to push out a bunch of bug fixes, my plan will be to just push multiple fixes this weekend without a long dev cycle. Users don't really understand dev so waiting for feedback from there wouldn't iterate very fast. |
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what I'm seeing in #282 and #233, it appears the Tesla API is already passing GCJ-02 coordinates for users in China in WGS-84 format. This was also confirmed by a user in China.
I'd like to merge this to dev and have some of our users in China test this out for us just to make sure, but everything I'm seeing suggests we can just use the
longitudeandlatitudevalues passed directly from the Tesla API for all users since it appears to in WGS-84 format which is what Home Assistant uses.