Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Will setting the charge limit to the same existing value wake the car if it's asleep? #379

Closed
cliffjao opened this issue Nov 28, 2022 · 2 comments · Fixed by zabuldon/teslajsonpy#378
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cliffjao
Copy link

Will setting the charge limit to the same existing value wake the car if it's asleep?

@cliffjao
Copy link
Author

Did a quick test and it looks like it does... Car changed from Disconnected to Connected state even though it's the same value. Would it make sense to only wake the car if the value actually changes?

@alandtse
Copy link
Owner

It could be added as a feature assuming we know the state without waking up. It woke up because you sent a command. We don't check for whether the command is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants