-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when there's no space after generic type parameters #596
Comments
Sorry for the delay! Agreed that this is a bug, though I looked into it a bit and it may end up being a tricky fix. Here's what I've found so far: The underlying issue is that the tokenizer is recognizing Babel has the same bug (Babel repl example), though it looks like it doesn't have the same problem with Flow, so there might be a reasonable fix by tracing that code path. TypeScript fixes it by always parsing the token as Another possible approach is to add a special case to |
Oh that's very interesting, we use Flow so I didn't realize that Babel could also be having trouble with this. Is this perhaps related to the fact that Flow doesn't have Anyway, this probably isn't a high priority blocker or anything. Writing |
I was taking a look at old bugs and noticed that this one seems to be working now! From some testing, it looks like it was fixed in version 3.24.0, most likely from the tokenizer changes in #717 . |
Input
causes a crash with both TypeScript and Flow transforms.
Error for the TS transform:
Adding a space between the
>
and=
fixes the issue.The text was updated successfully, but these errors were encountered: