Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpUtility to UriHelper migration scraps left over #3

Closed
timotei opened this issue Oct 5, 2010 · 1 comment
Closed

HttpUtility to UriHelper migration scraps left over #3

timotei opened this issue Oct 5, 2010 · 1 comment

Comments

@timotei
Copy link

timotei commented Oct 5, 2010

Hi!
yesterday when you removed the system.web dependecy, and instead created the UriHelper class, you forgot some changes. Here is the diff:

http://pastebin.com/iBuXMGuq

Regards,
Timo

@alanmcgovern
Copy link
Owner

Ah, bummer. I didn't push everything it seems. I pushed the rest of the changes which clear up usages in the tests aswell. Thanks! Also, since you're using git anyway, do check out the "fork and pull" model for issuing patches for future work. The workflow on github for dealing what patches that way is great!

Thanks for the patch!

@Vuyiswamb Vuyiswamb mentioned this issue May 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants