Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monotorrent may crush during change current date to some month back #5

Closed
misterion opened this issue Feb 28, 2011 · 4 comments
Closed

Comments

@misterion
Copy link

Subj can be produced for after client torrent engine start if change current time for some month back. This is so becouse of bug in MonoTorrent\MonoTorrent.Common\TimeoutDispatcher.cs line 155:

if (interval < TimeSpan.Zero)
{
interval = TimeSpan.Zero;
}
must be:

if (interval < TimeSpan.Zero || interval.TotalMilliseconds > Int32.MaxValue)
{
interval = TimeSpan.Zero;
}

Please fix it :)

@alanmcgovern
Copy link
Owner

This code doesn't exist anymore so I can only assume that whatever the issue was, it's already fixed in git. Can you verify that the problematic code you mentioned is gone or refactored to not display the issue?

@misterion
Copy link
Author

At least this file has still exist in master of mono torrent. We are using 0.9 version of mono torrent (mono-monotorrent-ee0b937) and this problem is actual in this version.

@alanmcgovern
Copy link
Owner

The file exists but the code you demonstrated doesn't any longer. If it does exist and I'm just not seeing it, can you fork monotorrent, make the required change and issue a pull request? http://help.github.com/pull-requests/

It's the easiest way to get changes such as this to me :)

@alanmcgovern
Copy link
Owner

I'm not sure if you closed this or I did, if I did then I didn't mean to close it yet ;)

I just checked, the issue has been fixed in git master but not in the 0.90 branch. Can you test with git master to verify the fix works as expected?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants