Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step prop #4

Closed
jared-94 opened this issue Feb 22, 2022 · 6 comments
Closed

Add step prop #4

jared-94 opened this issue Feb 22, 2022 · 6 comments

Comments

@jared-94
Copy link

Thanks for your great package!

As many other sliders it would be nice to have a step prop (for a discrete slider)

@alantoa
Copy link
Owner

alantoa commented Feb 22, 2022

Ok, I will add this feature later.You can follow this lib.

@jared-94
Copy link
Author

Thanks 👍

@alantoa
Copy link
Owner

alantoa commented Feb 25, 2022

@jared-94 Hi, I have added step feature, See example, you just use code:

<Slider
    progress={progress}
    minimumValue={min}
    maximumValue={max}
    step={10}
/>

Regrettably, I was busy, just simply did a test, I hope you can help me test it out.
If you have any questions, welcome to call me.
Finally, if you think it's good, please give me a Star, Thank you!

@alantoa alantoa closed this as completed Feb 27, 2022
@jared-94
Copy link
Author

jared-94 commented Mar 1, 2022

Thanks It works fine !

However, it seems that onSlidingComplete doesn't return the correct value...
Any idea?

@alantoa
Copy link
Owner

alantoa commented Mar 1, 2022

@jared-94 This is a bug, I will deal with it asap

@alantoa
Copy link
Owner

alantoa commented Mar 2, 2022

@jared-94 Hi, I fixed it!
You can try it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants