Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Emoji should be removed from github.com anchor #31

Open
kennytm opened this issue Aug 2, 2017 · 2 comments 路 May be fixed by #92
Open

Emoji should be removed from github.com anchor #31

kennytm opened this issue Aug 2, 2017 · 2 comments 路 May be fixed by #92

Comments

@kennytm
Copy link

kennytm commented Aug 2, 2017

  • macOS 10.12
  • VS Code 1.14.2
  • Markdown TOC 1.5.6 (2017-07-25)

Test case:

<!-- TOC updateOnSave:true -->

* [馃毑 Hello 馃毑](#馃毑-hello-馃毑)

<!-- /TOC -->

# 馃毑 Hello 馃毑

...

The generated anchor links to #馃毑-hello-馃毑, but on GitHub the actual anchor is #-hello-.

@anoff
Copy link

anoff commented Aug 14, 2017

This seems to have been fixed in 0.5.7. Should also be autofixed as the semVer range defined in this package is ^0.5.6. Since the fix was provided ~20 days ago in the dependency I assume you (like me) have a version that's older than 20 days. A simple reinstall on the extension page however doesn't do the trick for me to get the dependencies upgraded. Might be a package-lockor similar. Just head over to the directory and force an update

cd ~/.vscode/extensions/AlanWalk.markdown-toc-*
npm i anchor-markdown-header@0.5.7
# restart code completely

You can confirm the dependency version (before or afterwards):

cat ~/.vscode/extensions/AlanWalk.markdown-toc-*/node_modules/anchor-markdown-header/package.json| grep version

@mcornella
Copy link

mcornella commented Sep 22, 2020

This can be closed once 1.6.0 is released (in the VS marketplace).

@mcornella mcornella linked a pull request Sep 23, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants