Added Ubuntu gettext domain support #28
Conversation
… and comment from there overriding whatever values already were on .desktop
|
I have no clue what this is about. Is this available on all platforms or will we get problems if I merge this? Fedora, Opensuse, BSD, arch? |
|
I've not tested.... but it just looks for a Ubuntu key inside .desktop file. Nothing should happen if the key does not exists. I mean, default translation is selected. It is safe for non Ubuntu distros. |
|
What happens on systems like BSD? |
|
The patch just looks for "X-Ubuntu-Gettext-Domain" key inside desktop, and gets a name and generic name using gettext, instead of names provided by current .desktop file. That key shouldn't be in any Linux or BSD distro but Ubuntu based ones. |
|
Sure but this PR includes libintl.h. Which is GNU. A quick search scares me off: |
|
TBH, I dont know what happens on FreeBSD. Should be some sort of gettext support but I have no idea. I didnt have BSD in mind when I wrote the patch.
I'll take a look at that. |
ManuelSchneid3r
force-pushed
the
master
branch
4 times, most recently
from
d02fa40
to
7ac05a5
Compare
ManuelSchneid3r
force-pushed
the
master
branch
from
a5d13d8
to
ee55048
Compare
ManuelSchneid3r
requested review from
a team,
tyilo,
cyprienruffino,
XDjackieXD,
idkCpp and
CaseOf
|
Afaik the desktop files have their own localization. No need for external l18n. Then |
|
I'll close this one for now. See https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html. Let me know what you think. |
|
I reconsidered this one, if it makes problems on freebsd we could simply branch is using defines. |
|
recent version is now using gettext I changed a lot of other things as well in a general overhaul. thank you for pointing this out. |
This patch may solve issue 854. There is room for improvment, sure, ie: gettext domain may be defined but not present, so some sort of heuristic may decide best avaialable translation (desktop vs gettext)