Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add klipper plugin #186

Closed
wants to merge 1 commit into from
Closed

Conversation

hmnd
Copy link

@hmnd hmnd commented Sep 18, 2023

No description provided.

@ManuelSchneid3r
Copy link
Member

Dont want to be to picky but users will complain anyway. pulling pyside probably pulls the entire embedded qt stack. any chance to use https://dbus.freedesktop.org/doc/dbus-python/ ?

@ManuelSchneid3r
Copy link
Member

or rather https://pypi.org/project/pydbus/ since

dbus-python is a legacy API, built with a deprecated dbus-glib library, and involving a lot of type-guessing (despite "explicit is better than implicit" and "resist the temptation to guess").

@hmnd
Copy link
Author

hmnd commented Sep 19, 2023

@ManuelSchneid3r good point. I haven't worked with dbus much before so wasn't sure which lib to use 😅. Will switch it over to pydbus later today!

@hmnd
Copy link
Author

hmnd commented Sep 28, 2023

@ManuelSchneid3r looking at this again today... Perhaps python-sdbus might be an even better option? It seems to be the more actively maintained than the two libs you suggested.

@ManuelSchneid3r
Copy link
Member

in the end we need a small and stable library. if it is sustainable and does not pull hundreds of megabytes thats fine.

@ManuelSchneid3r
Copy link
Member

how is it going?

@ManuelSchneid3r
Copy link
Member

This issue was not intentionally but automatically closed because I renamed the master branch to main. If you are still interested in getting it merged please reopen against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants