Bitwarden enhancements #189
Conversation
This helps readability and performance. Before password and code subprocesses were running for each filtered_password. Now they only run when the user requests it.
Avoid abbreviations & acronyms, in favor of readability
'Unlock' item is unncesary because rbw binary by default asks for the master password on any action, like listing (__get_items). The only reason maybe to use it before might probably be to sync with the cloud items, and that can be done via 'rbw sync'.
There was a problem hiding this comment.
馃憤 for the contribution!
Minor styling issue: the "double underscore" could be replace with single underscore, which is traditionally used for private members.
[pep8] _single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose name starts with an underscore.
|
Sure!! I was kind of confused about that, but now I know. Thanks!! |
bitwarden/__init__.py
Outdated
| @@ -20,86 +20,35 @@ class Plugin(PluginInstance, TriggerQueryHandler): | |||
|
|
|||
| def __init__(self): | |||
| TriggerQueryHandler.__init__(self, | |||
| id=md_id, | |||
| id=md_iid, | |||
There was a problem hiding this comment.
dont use md_iid here. md_id is the id of the plugin, md_iid is the interface id, currently v2.1
There was a problem hiding this comment.
Sorry, I thought it was a misspelling because I didn't find where 'md_id' was declared, the linter marked as not defined
|
please also increase the version. |
|
Actually I meant the plugin version not the interface id. To me it looks like the plugin has some new features. If the UX changes make it 2.0 if it's just some non user recogniceable changes make it 1.4. |
Right, my bad... Well, I added an action (copy username), that's the only recognisable change in what respects to the user, not sure if that's enough to make a major, please confirm it. And should I leave the interface id in v2.1?? It's the currently active, isn't it? |
|
Go with md_version 2.0. I dont remember the additions to md_iid 2.1 exacty and forgot to document them. Yeah better leave 2.1 in there |
Primarily, I just wanted to add the 'copy_username' action because it's something I've been needing regularly these days. In the proccess of understanding I found a few things that could be improved, and I just did it. 馃 The commits have explanations of my decisions.
Initially, I considered keeping this changes local, but I then realized was the perfect time to help and do my first ever open source contribution. Hope to be helpful!
I'm totally open to debate and feedback, thanks!