fix [unit_converter]: Update unit_converter to API v2.1 #190
Conversation
unit_converter/__init__.py
Outdated
|
|
||
|
|
||
| md_iid = '2.0' | ||
| md_iid = "2.1" | ||
| md_version = "1.4" |
There was a problem hiding this comment.
please update the version if you change the extension.
There was a problem hiding this comment.
Good catch, fixed in 1d34d57
|
Been having some weird performance issues since having this plugin activated. Going to do a little more R&D before I post up for review, so going to close this for now. |
|
OK, have been testing this one for the past month and can confirm that the performance issues were unrelated to this one. Confident that this is now ready to merge, however may now conflict with #195 |
|
@ManuelSchneid3r after discussing with @ismasou I think we're good to go ahead and merge this branch and close #195 |
ManuelSchneid3r
force-pushed
the
master
branch
from
fc14def
to
98b135f
Compare
|
do I understand correctly that the unit converter is not coming back as both #195 and this have been closed without being merge? |
|
Happened accidentally. the change of the default branch automatically closed it. |
|
This issue was not intentionally but automatically closed because I renamed the master branch to main. If you are still interested in getting it merged please reopen against |
Updated the
unit_converterpython extension to work with API 2.1. Also added support for aGlobalQueryHandlervia the settings.@DenverCoder1 I added myself as a maintainer as I'm happy to keep an eye on this one in case of breaking API changes. As this is your work though I'm happy to remove myself if you would prefer it.