Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode workspace plugin #193

Conversation

lawrencegripper
Copy link

A simple plugin to list and launch recent VSCode workspaces

(Yeah the grep is horrible but there isn't a way to list this exposed via code CLI and grep works)

@Bierchermuesli
Copy link
Contributor

maybe just load the ~/.config/Code/User: vi globalStorage/storage.json instead of grep?

have a look on this existing plugin: https://github.com/Bierchermuesli/albert-vscode/tree/main (PR pending)

@ManuelSchneid3r
Copy link
Member

hey @Bierchermuesli, which PR are you talking of? did I miss something?

@Bierchermuesli
Copy link
Contributor

hey @Bierchermuesli, which PR are you talking of? did I miss something?

my fork into https://github.com/mparati31/albert-vscode , sorry about the confusion. Would you suggest a PR into albertlauncher/python ?

@ManuelSchneid3r
Copy link
Member

I am not that satisfied with either of them. Some ideas:

  • this pr is lean. i really like the minmalism. but…
  • grep is suboptimal, because it probably is not portable to other platforms. I dont understand the grep arguments, but if it just reads the file and finds pattern this should be solvable with pure python unsing regexes right?
  • mparati's approach looks bloaty in comparison.
  • IndexQueryHandler could be used with a hook into GlobalQueryHandler.handleQuery which checks the mdate of the file,builds a new index if it is newer and then relays to IndexQueryHandler.handleQuery. This way we get the global query handling, fuzzy search and the file will not be permanently read again. also response times are way faster, while this bunch of items should have a negligible memory impact.

@lawrencegripper
Copy link
Author

@ManuelSchneid3r thanks for 👀 - like these ideas 👍

I'll try and get some time to move over to python regex and IndexQueryHandler approach.

Others are welcome to pick this up ahead of me if they have more time.

@ManuelSchneid3r
Copy link
Member

This issue was not intentionally but automatically closed because I renamed the master branch to main. If you are still interested in getting it merged please reopen against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants