Resurrecting the unit_converter #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ismasou can you please join the chats for a discussion? community chats. |
|
@ManuelSchneid3r ahh sorry I didn't notice there was another pull request trying to do the same thing. I just joined the discord now, but I don't see chat about this. |
ManuelSchneid3r
force-pushed
the
master
branch
from
fc14def
to
98b135f
Compare
|
#190 as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick update to unit_converter to make it work with the new api.
It's working for me for a while now, but let me know if you find some problem.