Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEROSS-API-CHANGED] missing 1 required positional argument: 'skill_number' #274

Closed
impulsio opened this issue Jan 4, 2023 · 18 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@impulsio
Copy link
Contributor

impulsio commented Jan 4, 2023

Hello,
I have an issue with the latest version :
File "/usr/local/lib/python3.7/dist-packages/meross_iot/manager.py", line 343, in async_device_discovery
http_devices = await self._http_client.async_list_devices()
File "/usr/local/lib/python3.7/dist-packages/meross_iot/http_api.py", line 417, in async_list_devices
return [HttpDeviceInfo.from_dict(x) for x in result]
File "/usr/local/lib/python3.7/dist-packages/meross_iot/http_api.py", line 417, in
return [HttpDeviceInfo.from_dict(x) for x in result]
File "/usr/local/lib/python3.7/dist-packages/meross_iot/model/shared.py", line 27, in from_dict
obj = cls(**new_dict)

With this code (it's the call async_device_discovery that generate the error)

    http_api_client = await MerossHttpClient.async_from_user_password(args.muser, args.mpswd)
    logger.debug("Connected with user " + args.muser)
    # Register event handlers for the manager...
    manager = MerossManager(http_client=http_api_client)
    await manager.async_init()
    await manager.async_device_discovery()

Could you help me ?

@thefloe1
Copy link

thefloe1 commented Jan 4, 2023

Same for me. Tested on Windows with different Python Versions from 3.8 to 3.10 with 32bit and 64bit and library version 0.4.2.3 and 0.4.5.3.

@MichelRabozee
Copy link

Same for me... Strange enough, I updated yesterday, 19 hours ago, and it worked fine till 2 hours ago, while I clearly did not change anything between 19 hours ago and 2 hours ago...

@albertogeniola
Copy link
Owner

Hi,
that's a change on the Meross Cloud API that is breaking the library. I am now working to fix it.

@dpacecca
Copy link

dpacecca commented Jan 4, 2023

Hi, that's a change on the Meross Cloud API that is breaking the library. I am now working to fix it.

Thank you Alberto

@Raul-7-7
Copy link

Raul-7-7 commented Jan 4, 2023

Thank you Alberto!

@impulsio
Copy link
Contributor Author

impulsio commented Jan 4, 2023

Hi, that's a change on the Meross Cloud API that is breaking the library. I am now working to fix it.

Many thanks !

@dpacecca
Copy link

dpacecca commented Jan 4, 2023

@albertogeniola thanks for your good work, how do we apply the fix in Home Assistant?

@albertogeniola
Copy link
Owner

Hi @dpacecca ,
you just have to stay tuned here. When a fix is ready for HA I'll publish that there, with corresponding instructions.

@albertogeniola albertogeniola reopened this Jan 4, 2023
@albertogeniola albertogeniola self-assigned this Jan 4, 2023
@albertogeniola albertogeniola changed the title missing 1 required positional argument: 'skill_number' [MEROSS-API-CHANGED] missing 1 required positional argument: 'skill_number' Jan 4, 2023
@albertogeniola albertogeniola pinned this issue Jan 4, 2023
@dpacecca
Copy link

dpacecca commented Jan 4, 2023

Thanks, sorry I misunderstood that this was resolved :)

@albertogeniola
Copy link
Owner

For the ones using this library, you can now upgrade to v0.4.5.4, which includes the hotfix.
Please let me know if that solves the issue.

@MichelRabozee
Copy link

Everything is now OK ! You rock !

@albertogeniola
Copy link
Owner

I'm glad to hear that.
We've been lucky: the Meross breaking change occurred during my holidays :)

Jokes aside, It's just too bad people must now upgrade the library version to the latest one. I know of many IoT projects relying on this library to work and I'm afraid they will need to upgrade to keep them up and running.

@dpacecca
Copy link

dpacecca commented Jan 4, 2023

You're a legend, it is all working fine now, thanks!!

@albertogeniola enjoy your coffee!

@fletch904

This comment was marked as off-topic.

@albertogeniola

This comment was marked as off-topic.

@bryanminorphd
Copy link

Thank you @albertogeniola!! My orchids all thank you :)

@Topsham
Copy link

Topsham commented Jan 5, 2023

Have updated to 0.4.5.7 and all good. Thanks as always for the quick fixes.

@albertogeniola
Copy link
Owner

I'm glad it worked!

Repository owner locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants