/
test.py
353 lines (298 loc) · 13.9 KB
/
test.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
from collections import Counter
import os
import json
import sys
import tempfile
import typing # NOQA
import unittest
from unittest.mock import patch, MagicMock
from git_reviewers import reviewers
from git_reviewers.tests.fixtures import \
PHAB_DEFAULT_DATA, \
PHAB_ACTIVATED_DATA, \
PHAB_DISABLED_DATA
directory = os.path.dirname(os.path.realpath(__file__))
BASE_DIRECTORY = os.path.normpath(os.path.join(directory, '..', '..'))
class TestFindReviewers(unittest.TestCase):
def setUp(self) -> None:
self.finder = reviewers.FindReviewers(reviewers.Config())
self.orig_reviewers_limit = reviewers.REVIEWERS_LIMIT
def tearDown(self) -> None:
reviewers.REVIEWERS_LIMIT = self.orig_reviewers_limit
def test_get_reviewers(self) -> None:
with self.assertRaises(NotImplementedError):
self.finder.get_reviewers()
@patch('subprocess.run')
def test_run_command(self, mock_run: MagicMock) -> None:
mock_run().stdout = b'asdf'
data = self.finder.run_command(['ls'])
self.assertEqual(data, ['asdf'])
@patch('subprocess.run')
def test_run_command_empty_response(self, mock_run: MagicMock) -> None:
mock_run().stdout = b''
data = self.finder.run_command([':'])
self.assertEqual(data, [])
def check_extract_username(self, email: str, expected_user: str) -> None:
user = self.finder.extract_username_from_email(email)
self.assertEqual(user, expected_user)
def test_extract_username_from_generic_email(self) -> None:
self.check_extract_username('asdf@gmail.com', 'asdf@gmail.com')
def test_extract_uber_username_from_email(self) -> None:
self.check_extract_username('asdf@uber.com', 'asdf')
@patch('subprocess.Popen')
def test_check_phabricator_activated(self, mock_popen: MagicMock) -> None:
mock_popen().communicate.return_value = [PHAB_ACTIVATED_DATA, '']
activated = self.finder.check_phabricator_activated('asdf')
self.assertTrue(activated)
@patch('subprocess.Popen')
def test_check_phabricator_activated_none(
self, mock_popen: MagicMock
) -> None:
mock_popen().communicate.return_value = [PHAB_DEFAULT_DATA, '']
activated = self.finder.check_phabricator_activated('asdf')
self.assertTrue(activated)
def test_filter_phabricator_activated(self) -> None:
users = ['a', 'b', 'c', 'd']
reviewers.REVIEWERS_LIMIT = 2
self.mock_check_count = 0
def mock_check(u: str) -> int:
self.assertEqual(u, users[self.mock_check_count])
self.mock_check_count += 1
return self.mock_check_count - 1
self.mock_parse_count = 0
def mock_parse(u: str, p: int) -> str:
self.assertEqual(u, users[self.mock_parse_count])
self.assertEqual(p, self.mock_parse_count)
parse_return = ''
if self.mock_parse_count in [0, 2]:
parse_return = u
self.mock_parse_count += 1
return parse_return
self.finder.check_phabricator_activated = mock_check # type: ignore
self.finder.parse_phabricator = mock_parse # type: ignore
filtered_usernames = self.finder.filter_phabricator_activated(users)
self.assertEqual(self.mock_check_count, 3)
self.assertEqual(self.mock_parse_count, 3)
self.assertEqual(filtered_usernames, ['a', 'c'])
class TestFindLogReviewers(unittest.TestCase):
def setUp(self) -> None:
self.finder = reviewers.FindFileLogReviewers(reviewers.Config())
def check_extract_username_from_shortlog(
self, shortlog: str, email: str, weight: int
) -> None:
user_data = self.finder.extract_username_from_shortlog(shortlog)
self.assertEqual(user_data, (email, weight))
def test_gets_generic_emails(self) -> None:
shortlog = ' 3\tAlbert Wang <example@gmail.com>\n'
self.check_extract_username_from_shortlog(
shortlog,
'example@gmail.com',
3,
)
def test_gets_uber_emails(self) -> None:
shortlog = ' 3\tAlbert Wang <albertyw@uber.com>\n'
self.check_extract_username_from_shortlog(shortlog, 'albertyw', 3)
def test_gets_user_weight(self) -> None:
shortlog = ' 2\tAlbert Wang <albertyw@uber.com>\n'
self.check_extract_username_from_shortlog(shortlog, 'albertyw', 2)
def test_get_changed_files(self) -> None:
with self.assertRaises(NotImplementedError):
self.finder.get_changed_files()
@patch('subprocess.run')
def test_gets_reviewers(self, mock_run: MagicMock) -> None:
changed_files = ['README.rst']
self.finder.get_changed_files = ( # type: ignore
MagicMock(return_value=changed_files)
)
process = MagicMock()
git_shortlog = b' 3\tAlbert Wang <albertyw@uber.com>\n'
git_shortlog += b'3\tAlbert Wang <example@gmail.com>\n'
process.stdout = git_shortlog
mock_run.return_value = process
users = self.finder.get_reviewers()
reviewers = Counter({'albertyw': 3, 'example@gmail.com': 3})
self.assertEqual(users, reviewers)
class TestLogReviewers(unittest.TestCase):
def setUp(self) -> None:
self.finder = reviewers.FindLogReviewers(reviewers.Config())
def test_get_changed_files(self) -> None:
changed_files = ['README.rst', 'pyproject.toml']
self.finder.run_command = ( # type: ignore
MagicMock(return_value=changed_files)
)
files = self.finder.get_changed_files()
self.assertEqual(files, ['README.rst', 'pyproject.toml'])
class TestHistoricalReviewers(unittest.TestCase):
def setUp(self) -> None:
self.finder = reviewers.FindHistoricalReviewers(reviewers.Config())
def test_get_reviewers(self) -> None:
counter = Counter() # type: typing.Counter[str]
mock_get_log_reviewers = MagicMock(return_value=counter)
self.finder.get_log_reviewers_from_file = ( # type: ignore
mock_get_log_reviewers
)
reviewers = self.finder.get_reviewers()
self.assertEqual(counter, reviewers)
class TestFindArcCommitReviewers(unittest.TestCase):
def setUp(self) -> None:
self.finder = reviewers.FindArcCommitReviewers(reviewers.Config())
def test_no_reviewers(self) -> None:
log = ['asdf']
self.finder.run_command = MagicMock(return_value=log) # type: ignore
reviewers = self.finder.get_log_reviewers_from_file(['file'])
self.assertEqual(reviewers, Counter())
def test_reviewers(self) -> None:
log = ['asdf', ' Reviewed By: asdf, qwer']
self.finder.run_command = MagicMock(return_value=log) # type: ignore
reviewers = self.finder.get_log_reviewers_from_file(['file'])
self.assertEqual(reviewers, Counter({'asdf': 1, 'qwer': 1}))
def test_multiple_reviews(self) -> None:
log = ['asdf', ' Reviewed By: asdf, qwer', 'Reviewed By: asdf']
self.finder.run_command = MagicMock(return_value=log) # type: ignore
reviewers = self.finder.get_log_reviewers_from_file(['file'])
self.assertEqual(reviewers, Counter({'asdf': 2, 'qwer': 1}))
class TestShowReviewers(unittest.TestCase):
@patch('builtins.print')
def test_show_reviewers(self, mock_print: MagicMock) -> None:
usernames = ['asdf', 'albertyw']
reviewers.show_reviewers(usernames, False)
mock_print.assert_called_with('asdf, albertyw')
@patch('subprocess.Popen')
def test_copy_reviewers(self, mock_popen: MagicMock) -> None:
usernames = ['asdf', 'albertyw']
reviewers.show_reviewers(usernames, True)
self.assertTrue(mock_popen.called)
@patch('subprocess.Popen')
def test_copy_reviewers_no_pbcopy(self, mock_popen: MagicMock) -> None:
usernames = ['asdf', 'albertyw']
mock_popen.side_effect = FileNotFoundError
reviewers.show_reviewers(usernames, True)
class TestGetReviewers(unittest.TestCase):
@patch('builtins.print')
def test_verbose_reviewers(self, mock_print: MagicMock) -> None:
config = reviewers.Config()
config.verbose = True
counter = Counter({'asdf': 1, 'qwer': 1})
get_reviewers = (
'git_reviewers.reviewers.'
'FindFileLogReviewers.get_reviewers'
)
run_command = 'git_reviewers.reviewers.FindReviewers.run_command'
with patch.object(sys, 'argv', ['reviewers.py', '--verbose']):
with patch(get_reviewers) as mock_get_reviewers:
with patch(run_command) as mock_run_command:
with patch('subprocess.Popen') as mock_popen:
mock_popen().returncode = 0
mock_popen().communicate.return_value = \
[PHAB_ACTIVATED_DATA, b'']
mock_run_command.return_value = []
mock_get_reviewers.return_value = counter
reviewers.get_reviewers(config)
self.assertEqual(len(mock_print.call_args), 2)
self.assertEqual(
mock_print.call_args[0][0],
'Reviewers from FindArcCommitReviewers: %s' %
"{'asdf': 1, 'qwer': 1}"
)
class TestConfig(unittest.TestCase):
def setUp(self) -> None:
self.config = reviewers.Config()
self.config_file = tempfile.NamedTemporaryFile('w')
self.mock_args = MagicMock()
self.mock_args.verbose = None
self.mock_args.ignore = ''
self.mock_args.json = ''
self.mock_args.copy = None
def tearDown(self) -> None:
self.config_file.close()
def test_default_global_json(self) -> None:
expected_path = os.path.expanduser("~") + "/.git/reviewers"
json_path = reviewers.Config.default_global_json()
self.assertEqual(json_path, expected_path)
def test_read_configs_args(self) -> None:
self.mock_args.verbose = True
self.config.read_configs(self.mock_args)
self.assertTrue(self.config.verbose)
self.assertEqual(self.config.ignores, [])
self.assertFalse(self.config.copy)
def test_read_configs_copy(self) -> None:
self.mock_args.copy = True
self.config.read_configs(self.mock_args)
self.assertTrue(self.config.copy)
def test_read_json(self) -> None:
self.mock_args.ignore = 'a,b'
self.mock_args.json = self.config_file.name
config_file_data = {'verbose': True, 'ignore': ['c', 'd']}
self.config_file.write(json.dumps(config_file_data))
self.config_file.flush()
self.config.read_configs(self.mock_args)
self.assertTrue(self.config.verbose)
self.assertEqual(set(self.config.ignores), set(['a', 'b', 'c', 'd']))
def test_read_malformed_json(self) -> None:
self.mock_args.ignore = 'a,b'
self.mock_args.json = self.config_file.name
self.config_file.write('')
self.config_file.flush()
self.config.read_configs(self.mock_args)
self.assertEqual(set(self.config.ignores), set(['a', 'b']))
def test_read_unusable(self) -> None:
self.mock_args.ignore = 'a,b'
self.mock_args.json = self.config_file.name
self.config_file.write("[]")
self.config_file.flush()
self.config.read_configs(self.mock_args)
self.assertEqual(set(self.config.ignores), set(['a', 'b']))
class TestMain(unittest.TestCase):
@patch('builtins.print')
def test_main(self, mock_print: MagicMock) -> None:
with patch.object(sys, 'argv', ['reviewers.py']):
reviewers.main()
self.assertTrue(mock_print.called)
@patch('argparse.ArgumentParser._print_message')
def test_version(self, mock_print: MagicMock) -> None:
with patch.object(sys, 'argv', ['reviewers.py', '-v']):
with self.assertRaises(SystemExit):
reviewers.main()
self.assertTrue(mock_print.called)
version = reviewers.__version__ + "\n"
self.assertEqual(mock_print.call_args[0][0], version)
@patch('builtins.print')
def test_ignore_reviewers(self, mock_print: MagicMock) -> None:
counter = Counter({'asdf': 1, 'qwer': 1})
get_reviewers = (
'git_reviewers.reviewers.'
'FindFileLogReviewers.get_reviewers'
)
run_command = 'git_reviewers.reviewers.FindReviewers.run_command'
with patch.object(sys, 'argv', ['reviewers.py', '-i', 'asdf']):
with patch(get_reviewers) as mock_get_reviewers:
with patch(run_command) as mock_run_command:
with patch('subprocess.Popen') as mock_popen:
mock_popen().returncode = 0
mock_popen().communicate.return_value = \
[PHAB_ACTIVATED_DATA, b'']
mock_run_command.return_value = []
mock_get_reviewers.return_value = counter
reviewers.main()
self.assertEqual(mock_print.call_args[0][0], 'qwer')
@patch('builtins.print')
def test_phabricator_disabled_reviewers(
self, mock_print: MagicMock
) -> None:
counter = Counter({'asdf': 1, 'qwer': 1})
get_reviewers = (
'git_reviewers.reviewers.'
'FindFileLogReviewers.get_reviewers'
)
run_command = 'git_reviewers.reviewers.FindReviewers.run_command'
with patch.object(sys, 'argv', ['reviewers.py']):
with patch(get_reviewers) as mock_get_reviewers:
with patch(run_command) as mock_run_command:
with patch('subprocess.Popen') as mock_popen:
mock_popen().returncode = 0
mock_popen().communicate.return_value = \
[PHAB_DISABLED_DATA, b'']
mock_run_command.return_value = []
mock_get_reviewers.return_value = counter
reviewers.main()
self.assertEqual(mock_print.call_args[0][0], '')