Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine behavior when tilesets are removed #45

Closed
albin-johansson opened this issue Apr 21, 2022 · 0 comments
Closed

Determine behavior when tilesets are removed #45

albin-johansson opened this issue Apr 21, 2022 · 0 comments
Labels
enhancement New feature or request ux Related to user experience
Projects
Milestone

Comments

@albin-johansson
Copy link
Owner

Currently, when a tileset is removed, the tile layers remain untouched. This means that they may contain invalid tile identifiers.

There are several ways to deal with this. We could add an action for fixing invalid tile identifiers, going through the tiles and setting invalid ones to be empty. Alternatively, the command responsible for removing tilesets could cache all tiles from the tileset, and subsequently set them to be empty. This approach would always keep the map in a "good" state, and allow for better state restoration upon undoing the tileset removal.

Since it's possible to import maps with invalid tiles, we should probably pursue both strategies.

Requirements

  • Add "Fix Invalid Tiles" action
  • Make tileset removal command cache the affected tiles, and restore them as needed
@albin-johansson albin-johansson added enhancement New feature or request ux Related to user experience labels Apr 21, 2022
@albin-johansson albin-johansson added this to the Tactile 0.4.0 milestone Apr 21, 2022
@albin-johansson albin-johansson added this to TODO in Tactile Apr 21, 2022
@albin-johansson albin-johansson moved this from TODO to In Progress in Tactile May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux Related to user experience
Projects
No open projects
Tactile
In Progress
Development

No branches or pull requests

1 participant