Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate sdk + nft contract for onboarding #11

Merged
merged 3 commits into from Jun 7, 2023

Conversation

rthomare
Copy link
Collaborator

@rthomare rthomare commented Jun 2, 2023

This Stack

This pull request introduces a comprehensive end-to-end decentralized application that serves as a prime example for users of our SDK, providing a practical demonstration of various interactions and functionalities, fostering a solid foundation for their own development endeavors.

This PR

Compiles and update NFT Contract and ABI, and adds first version of onboarding

Test Plan

test.example.mov

@rthomare rthomare requested a review from moldy530 June 2, 2023 02:11
packages/core/package.json Outdated Show resolved Hide resolved
metaForStepIdentifier,
} from "./OnboardingDataModels";

async function pollForLambdaForComplete(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh so you shouldn't need this if you're waiting for UOs to complete anymore. The SDK has a sendTransaction method available that will handle this for you and return a tx_hash instead of a UO hash

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need this function for a Faucet check but sounds good for the user op!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this up stack because I do a major onboarding refactor later on.

Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we omit all of the out from building the contracts? might be nice to use something like the wagmi cli for generating the ABI defs eg: https://github.com/OMGWINNING/ens-offchain-resolver/pull/2#discussion_r1203166796

we can also gitignore the generated files too and have a predev script defined that makes sure the wagmi cli generates the files

@rthomare rthomare force-pushed the rohan/feature/example-daapp-3 branch 2 times, most recently from 8a3d496 to eb3b14f Compare June 6, 2023 00:48
Base automatically changed from rohan/feature/example-daapp-3 to main June 6, 2023 00:48
@rthomare rthomare force-pushed the rohan/feature/example-dapp-4 branch from e51a416 to 7d238e1 Compare June 6, 2023 02:38
@rthomare
Copy link
Collaborator Author

rthomare commented Jun 6, 2023

Will do the wagmi based cli for abi generation in a follow up PR.

@rthomare rthomare force-pushed the rohan/feature/example-dapp-4 branch from 7d238e1 to 245641f Compare June 6, 2023 02:52
@rthomare rthomare requested a review from moldy530 June 6, 2023 14:04
import { RequestFunds } from "./RequestFunds";

// .01 in wei
export const MIN_ONBOARDING_WALLET_BALANCE = BigInt("10000000000000000");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to do 10_000_000_000_000_000n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants