Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements needed for example code, including URL and typo issues #110

Closed
IgorShadurin opened this issue Oct 2, 2023 · 0 comments · Fixed by #111
Closed

General improvements needed for example code, including URL and typo issues #110

IgorShadurin opened this issue Oct 2, 2023 · 0 comments · Fixed by #111
Labels
bug Something isn't working

Comments

@IgorShadurin
Copy link
Contributor

[REQUIRED] Environment

  • Browser version: N/A
  • AA SDK version: N/A
  • Package: N/A

[REQUIRED] Describe the problem

The example API and codebase have some issues that need to be addressed for better clarity and functionality.

  1. URL Generation Issue:

    • When address is not passed, the API has an issue with URL generation. This results in failed API calls or incorrect behavior.

  2. Typos in Code and UI:

    • Various typos exist in the following files:
      • examples/alchemy-daapp/src/pages/api/nfts.ts
      • examples/alchemy-daapp/src/surfaces/connect/ConnectPage.tsx
      • examples/alchemy-daapp/src/surfaces/onboarding/OnboardingController.ts
      • examples/alchemy-daapp/src/surfaces/profile/NftSection.tsx

Relevant code or sample repo:

https://github.com/alchemyplatform/aa-sdk/tree/main/examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: general improvements to the examples section IgorShadurin/aa-sdk
1 participant
@IgorShadurin