feat: add sanity check on provider connect for clearer error message #181

denniswon · 2023-10-29T21:47:06Z

app.asana.com/0/1205598840815267/1205773893380310/f

Per the task linked above, added a sanity check early on on the current connect() so that users can get clear error message about the issue.

Follow up PR will made to make entry point contract address param as optional for SmartContractAccount

Also, updated the doc for the missing/added Other methods for SCA class.

PR-Codex overview

Detailed summary:

This PR introduces the getEntryPointAddress method to the ISmartContractAccount interface and the BaseSmartContractAccount class. It also adds implementations and documentation for the method in various files. Additionally, it updates the SmartAccountProvider class to use the connected account's entry point address or the default entry point address for the chain.

The following files were skipped due to too many changes: packages/core/src/provider/__tests__/base.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

packages/core/src/provider/__tests__/base.test.ts

avasisht23

few comments/suggestions

packages/core/src/provider/__tests__/base.test.ts

site/packages/aa-core/accounts/other/getOwner.md

packages/core/src/provider/base.ts

…rer error

…or entry point address iff optional entry point param is given on init

avasisht23

this looks good. few nits, then 🚢

packages/core/src/provider/__tests__/base.test.ts

packages/core/src/provider/base.ts

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

denniswon requested review from moldy530, rthomare, dancoombs, mokok123 and avasisht23 as code owners October 29, 2023 21:47

denniswon force-pushed the denniswon/entrypoint-validation branch from d00e59a to f993fb7 Compare October 29, 2023 21:49

denniswon changed the base branch from development to denniswon/abstract-entrypoint October 29, 2023 21:49

denniswon force-pushed the denniswon/abstract-entrypoint branch from bc2e02b to f2717f8 Compare October 30, 2023 02:59

denniswon force-pushed the denniswon/entrypoint-validation branch from f993fb7 to ecf61aa Compare October 30, 2023 03:01

denniswon force-pushed the denniswon/abstract-entrypoint branch 2 times, most recently from 8ff1972 to 1b90588 Compare October 30, 2023 03:32

denniswon force-pushed the denniswon/entrypoint-validation branch from ecf61aa to 5c36999 Compare October 30, 2023 03:33

denniswon changed the title ~~feat: add sanity check on provider connect so that users can get clear error message~~ feat: add sanity check on provider connect for clearer error message Oct 30, 2023

moldy530 reviewed Oct 30, 2023

View reviewed changes

packages/core/src/provider/__tests__/base.test.ts Outdated Show resolved Hide resolved

avasisht23 reviewed Oct 30, 2023

View reviewed changes

denniswon force-pushed the denniswon/abstract-entrypoint branch 2 times, most recently from 68628f2 to a05006f Compare October 30, 2023 21:19

Base automatically changed from denniswon/abstract-entrypoint to development October 30, 2023 21:25

denniswon force-pushed the denniswon/entrypoint-validation branch from c8f5c1d to 9194213 Compare October 30, 2023 23:32

This was referenced Oct 31, 2023

feat: add zod runtime validation for base account #186

Merged

feat: add zod runtime validation for ethers adapter provider #188

Merged

denniswon added 2 commits October 30, 2023 18:55

feat: add sanity check on provider connect so that users can get clea…

b3344eb

…rer error

feat: update provider connect to perform validation against account f…

bb048fd

…or entry point address iff optional entry point param is given on init

denniswon force-pushed the denniswon/entrypoint-validation branch from 9194213 to bb048fd Compare October 31, 2023 01:56

avasisht23 approved these changes Oct 31, 2023

View reviewed changes

denniswon and others added 5 commits October 30, 2023 22:43

Update packages/core/src/provider/__tests__/base.test.ts

3d46827

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

Update packages/core/src/provider/__tests__/base.test.ts

5b3358d

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

Update packages/core/src/provider/base.ts

5b4808e

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

Update packages/core/src/provider/base.ts

7192d2c

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

Update packages/core/src/provider/__tests__/base.test.ts

34ccb8b

Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

feat: use ingInlineSnapshot matching for provider base test

98a8d56

denniswon merged commit 7bd1e47 into development Oct 31, 2023
3 checks passed

denniswon deleted the denniswon/entrypoint-validation branch October 31, 2023 05:58

avasisht23 added a commit that referenced this pull request Nov 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

52ab34c

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Nov 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

490235a

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Nov 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

1739f13

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 mentioned this pull request Nov 10, 2023

feat!: cut new release #233

Merged

moldy530 pushed a commit that referenced this pull request Nov 10, 2023

feat: add sanity check on provider connect for clearer error message (#…

91b2703

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 pushed a commit that referenced this pull request Nov 10, 2023

feat: add sanity check on provider connect for clearer error message (#…

a882bec

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 mentioned this pull request Nov 10, 2023

chore: merge back into main after manual deploys [skip-ci] #235

Merged

avasisht23 added a commit that referenced this pull request Nov 14, 2023

feat: add sanity check on provider connect for clearer error message (#…

9d21fc9

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Nov 14, 2023

feat: add sanity check on provider connect for clearer error message (#…

f64559c

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Nov 14, 2023

feat: add sanity check on provider connect for clearer error message (#…

514feb2

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Nov 14, 2023

feat: add sanity check on provider connect for clearer error message (#…

33798c2

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

denniswon added a commit that referenced this pull request Nov 16, 2023

feat: add sanity check on provider connect for clearer error message (#…

a288af6

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

denniswon added a commit that referenced this pull request Nov 16, 2023

feat: add sanity check on provider connect for clearer error message (#…

a500842

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 pushed a commit that referenced this pull request Nov 16, 2023

feat: add sanity check on provider connect for clearer error message (#…

97a9b98

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 pushed a commit that referenced this pull request Nov 16, 2023

feat: add sanity check on provider connect for clearer error message (#…

0244c8c

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

moldy530 mentioned this pull request Nov 17, 2023

chore: release/v1.2.0 #268

Merged

7 tasks

moldy530 mentioned this pull request Dec 1, 2023

chore: release v1.3.0 #295

Merged

8 tasks

avasisht23 added a commit that referenced this pull request Dec 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

2368867

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Dec 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

cd8d825

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Dec 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

a1f0527

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

avasisht23 added a commit that referenced this pull request Dec 3, 2023

feat: add sanity check on provider connect for clearer error message (#…

6c70771

…181) Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add sanity check on provider connect for clearer error message #181

feat: add sanity check on provider connect for clearer error message #181

denniswon commented Oct 29, 2023 •

edited by pr-codex bot

avasisht23 left a comment

avasisht23 left a comment

feat: add sanity check on provider connect for clearer error message #181

feat: add sanity check on provider connect for clearer error message #181

Conversation

denniswon commented Oct 29, 2023 • edited by pr-codex bot

PR-Codex overview

Detailed summary:

avasisht23 left a comment

Choose a reason for hiding this comment

avasisht23 left a comment

Choose a reason for hiding this comment

denniswon commented Oct 29, 2023 •

edited by pr-codex bot