-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zod runtime validation for simple account #189
Merged
avasisht23
merged 1 commit into
development
from
10-30-feat_add_zod_runtime_validation_for_simple_account
Nov 2, 2023
Merged
feat: add zod runtime validation for simple account #189
avasisht23
merged 1 commit into
development
from
10-30-feat_add_zod_runtime_validation_for_simple_account
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
October 31, 2023 01:19
This was referenced Oct 31, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
7 tasks
denniswon
reviewed
Oct 31, 2023
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
October 31, 2023 03:30
5a88163
to
5c2280b
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
October 31, 2023 03:30
d012b78
to
0cb44b5
Compare
moldy530
reviewed
Oct 31, 2023
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 15:37
5c2280b
to
700d1b1
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 1, 2023 15:37
0cb44b5
to
99e29aa
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:03
700d1b1
to
4249a75
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 1, 2023 17:03
99e29aa
to
8e10110
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:06
4249a75
to
a26f1d8
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
2 times, most recently
from
November 1, 2023 17:10
a2abeac
to
a46b2d7
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:27
b192f03
to
3fee977
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 1, 2023 17:27
a46b2d7
to
8d9baa0
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:30
3fee977
to
e67627f
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 1, 2023 17:30
8d9baa0
to
3650926
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 2, 2023 04:16
e67627f
to
04ce1b8
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 2, 2023 04:16
3650926
to
dea662f
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 2, 2023 17:56
04ce1b8
to
1abeafa
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 2, 2023 17:56
dea662f
to
fdc0ce2
Compare
denniswon
approved these changes
Nov 2, 2023
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 2, 2023 19:32
1abeafa
to
64a582c
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 2, 2023 19:32
fdc0ce2
to
c57eb6b
Compare
Base automatically changed from
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
to
development
November 2, 2023 19:57
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
from
November 2, 2023 19:58
c57eb6b
to
44d126e
Compare
avasisht23
deleted the
10-30-feat_add_zod_runtime_validation_for_simple_account
branch
November 2, 2023 20:02
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
Merged
moldy530
pushed a commit
that referenced
this pull request
Nov 10, 2023
avasisht23
added a commit
that referenced
this pull request
Nov 14, 2023
avasisht23
added a commit
that referenced
this pull request
Nov 14, 2023
denniswon
pushed a commit
that referenced
this pull request
Nov 16, 2023
moldy530
pushed a commit
that referenced
this pull request
Nov 16, 2023
avasisht23
added a commit
that referenced
this pull request
Dec 3, 2023
avasisht23
added a commit
that referenced
this pull request
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, see guidleines below)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
Detailed summary
SimpleSmartAccountParamsSchema
function inpackages/core/src/account/schema.ts
to create a schema for simple smart account parameters.packages/core/src/index.ts
to exportSimpleSmartAccountParamsSchema
.packages/core/src/account/__tests__/simple.test.ts
to add a test for runtime validation of invalid index.packages/core/src/account/types.ts
to importSimpleSmartAccountParamsSchema
and update theSimpleSmartAccountParams
type.packages/core/src/account/simple.ts
to importSimpleSmartAccountParamsSchema
and update the constructor to validate the params using the schema.