Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use alchemy provider, light account for e2e tests #209

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Nov 3, 2023

We should use AlchemyProvider with gas manager for all our e2e tests to less make it flaky.
Also, use light accounts unless for simple account tests.

For Kernel, just utilizing fee data getter override to set test passing variables.


PR-Codex overview

Detailed summary

  • Added @alchemy/aa-alchemy as a devDependency in packages/accounts/package.json.
  • Updated constants.ts files in various packages to include new environment variables and remove unnecessary ones.
  • Updated base.ts in packages/core/src/provider to use const instead of let for maxPriorityFeePerGasBid.
  • Updated imports and network configurations in various test files to use sepolia chain instead of polygonMumbai.
  • Updated withFeeDataGetter.md in site/packages/aa-core/provider to use new fee values.
  • Updated imports and network configurations in simple-account.test.ts files to use sepolia chain instead of polygonMumbai.
  • Updated imports and network configurations in kernel-account.test.ts file to use MUMBAI_RPC_URL instead of RPC_URL.
  • Updated imports and network configurations in simple-account.test.ts file to use MUMBAI_RPC_URL instead of RPC_URL.
  • Updated imports and network configurations in light-account.test.ts file to use AlchemyProvider from @alchemy/aa-alchemy and LightSmartContractAccount from ../../index.js.

The following files were skipped due to too many changes: packages/accounts/src/light-account/e2e-tests/light-account.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@moldy530
Copy link
Collaborator

moldy530 commented Nov 3, 2023

Are all the changes in this PR relevant? Seems like it includes way more than e2e updates?

@avasisht23
Copy link
Contributor

sorry @denniswon I just rebased dev on main after pulling in the changes for a new version.

make sure to rebase this PR on dev again

@denniswon denniswon self-assigned this Nov 3, 2023
@denniswon denniswon force-pushed the denniswon/e2e branch 2 times, most recently from e417413 to d9a1161 Compare November 3, 2023 23:06
@denniswon denniswon force-pushed the denniswon/e2e branch 3 times, most recently from 145186f to 28fbf96 Compare November 5, 2023 19:39
Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few nits

packages/core/package.json Outdated Show resolved Hide resolved
@denniswon denniswon force-pushed the denniswon/e2e branch 2 times, most recently from f5b37fb to 1cd86c5 Compare November 6, 2023 00:30
@denniswon denniswon force-pushed the denniswon/e2e branch 2 times, most recently from df37bf1 to 50b87dc Compare November 6, 2023 00:32
@denniswon denniswon force-pushed the denniswon/e2e branch 2 times, most recently from cc69c0a to b34d1d3 Compare November 6, 2023 01:14
@denniswon denniswon merged commit 124be68 into development Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants