Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: choosing your signer, light account, modular account doc update #215

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: choosing your signer, light account, modular account doc update #215

merged 1 commit into from
Nov 7, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Nov 6, 2023 •
edited by pr-codex bot

PR-Codex overview

Detailed summary

  • Added a link to the account factory's code in getAccountInitCode documentation.
  • Updated links in the introduction.md file.
  • Updated content in the choosing-a-smart-account.md file.
  • Updated content in the modular-account.md file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon mentioned this pull request Nov 6, 2023
Merged
avasisht23
avasisht23 suggested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the intro/overview docs as a separate item.

this was feedback from Will that it's unintuitive to click on the section header and expect a page, vs. having it be more explicit and visible as a standalone link with something like "Overview"

@denniswon denniswon changed the title feat: make entire format of our doc site consistent and concise feat: choosing your signer, light account, modular account doc update Nov 7, 2023
@denniswon
Copy link
Contributor Author

@avasisht23 separated the pr with #217

I will accommodate your comment above on that pr.

avasisht23
avasisht23 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@avasisht23 avasisht23 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just relint the config.ts file. missing an EOF newline.

@denniswon denniswon merged commit f05b92d into development Nov 7, 2023
3 checks passed
@denniswon denniswon deleted the denniswon/docs branch November 7, 2023 17:32
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
moldy530 pushed a commit that referenced this pull request Nov 10, 2023
@denniswon @rthomare @moldy530
feat: choosing your signer, light account, modular account doc update (…
3c944d6 
…#215)

Co-authored-by: Rohan Thomare <rohanthomare@gmail.com>
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avasisht23 avasisht23 avasisht23 approved these changes

@moldy530 moldy530 Awaiting requested review from moldy530 moldy530 is a code owner

@rthomare rthomare Awaiting requested review from rthomare rthomare is a code owner

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@mokok123 mokok123 Awaiting requested review from mokok123 mokok123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@denniswon @avasisht23 @rthomare