Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enhanced apis in alchemy provider #221

Merged

Conversation

avasisht23
Copy link
Contributor

@avasisht23 avasisht23 commented Nov 7, 2023

Pull Request Checklist

  • Did you add new tests and confirm existing tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the site folder, see guidleines below)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
  • Is the base branch you're merging into development and not main?

PR-Codex overview

Detailed summary

  • Added alchemy-sdk as a peer dependency in package.json.
  • Imported Alchemy from alchemy-sdk in multiple files.
  • Added AlchemySdkClientSchema to validate the Alchemy instance.
  • Added withAlchemyEnhancedApis method to extend the provider with Alchemy SDK client methods.
  • Updated tests to use the new withAlchemyEnhancedApis method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor Author

avasisht23 commented Nov 7, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@avasisht23 avasisht23 force-pushed the 11-07-feat_support_enhanced_apis_in_alchemy_provider branch from edcbba6 to b547b56 Compare November 8, 2023 06:25
@avasisht23 avasisht23 mentioned this pull request Nov 8, 2023
7 tasks
@avasisht23 avasisht23 merged commit 83ea17f into development Nov 8, 2023
3 checks passed
@avasisht23 avasisht23 deleted the 11-07-feat_support_enhanced_apis_in_alchemy_provider branch November 8, 2023 15:52
);
}

const alchemyUrl = `https://${alchemy.config.network}.g.alchemy.com/v2/${alchemy.config.apiKey}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should check the network as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants