Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add magic signer to aa-signers #229

Merged
merged 27 commits into from
Nov 28, 2023

Conversation

avasisht23
Copy link
Contributor

@avasisht23 avasisht23 commented Nov 8, 2023

Pull Request Checklist

  • Did you add new tests and confirm existing tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the site folder, see guidleines below)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
  • Is the base branch you're merging into development and not main?

PR-Codex overview

Detailed summary

This PR introduces the MagicSigner class in the @alchemy/aa-signers package. It includes the following changes:

  • Deleted packages/signers/src/__tests__/signer.test.ts
  • Added export { MagicSigner } from "./signer.js" and export type * from "./types.js" in packages/signers/src/index.ts
  • Added "magic-sdk": "^21.3.0" as an optional dependency in packages/signers/package.json
  • Added new files packages/signers/src/magic/types.ts and packages/signers/src/magic/signer.ts
  • Added new methods getAddress, signMessage, signTypedData, authenticate, and getAuthDetails in packages/signers/src/magic/signer.ts
  • Added new files site/packages/aa-signers/magic/getAddress.md, site/packages/aa-signers/magic/signMessage.md, site/packages/aa-signers/magic/getAuthDetails.md, site/packages/aa-signers/magic/constructor.md, and site/packages/aa-signers/magic/signTypedData.md
  • Updated site/.vitepress/config.ts to include documentation links for Magic Signer

The following files were skipped due to too many changes: site/packages/aa-signers/magic/signTypedData.md, yarn.lock, site/packages/aa-signers/magic/authenticate.md, site/packages/aa-signers/magic/introduction.md, packages/signers/src/magic/__tests__/signer.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor Author

avasisht23 commented Nov 8, 2023

@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from 0b929a0 to 0788f39 Compare November 8, 2023 22:29
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 552cc7d to 6658903 Compare November 8, 2023 22:30
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from 0788f39 to 8b734fa Compare November 8, 2023 22:40
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 6658903 to e33397d Compare November 8, 2023 22:40
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from 8b734fa to 3e7efe6 Compare November 8, 2023 22:40
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from e33397d to f6f71ca Compare November 8, 2023 22:40
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from 3e7efe6 to f3034b9 Compare November 9, 2023 20:46
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from f6f71ca to bd37ad8 Compare November 9, 2023 20:46
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from f3034b9 to 5796631 Compare November 12, 2023 20:08
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from bd37ad8 to d206a7e Compare November 12, 2023 20:08
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_aa-signers_package branch from 5796631 to f42443e Compare November 12, 2023 20:53
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from d206a7e to 5ff03ab Compare November 12, 2023 20:53
@avasisht23 avasisht23 marked this pull request as ready for review November 13, 2023 18:12
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 6647ecb to 19d06a7 Compare November 27, 2023 22:29
Copy link

@mynamebrody mynamebrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly ran through from the Magic side. Looking good!

packages/signers/package.json Outdated Show resolved Hide resolved
packages/signers/src/magic/signer.ts Show resolved Hide resolved
@avasisht23
Copy link
Contributor Author

avasisht23 commented Nov 28, 2023

Merge activity

@avasisht23 avasisht23 merged commit 37db750 into development Nov 28, 2023
3 checks passed
@avasisht23 avasisht23 deleted the 11-08-feat_add_magic_signer_to_aa-signers branch November 28, 2023 18:59
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
8 tasks
moldy530 pushed a commit that referenced this pull request Dec 1, 2023
moldy530 pushed a commit that referenced this pull request Dec 1, 2023
avasisht23 added a commit that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants