Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove AA_SDK_TESTS_SIGNER_TYPE constant exported from aa-core #232

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Nov 9, 2023

PR-Codex overview

Detailed summary

  • The focus of this PR is to replace the constant AA_SDK_TESTS_SIGNER_TYPE with the string value "aa-sdk-tests" in multiple files.
  • The changes include replacing AA_SDK_TESTS_SIGNER_TYPE with "aa-sdk-tests" in the following files:
    • packages/core/src/signer/types.ts
    • packages/core/src/index.ts
    • packages/alchemy/src/__tests__/provider.test.ts
    • packages/accounts/src/kernel-zerodev/__tests__/mocks/mock-signer.ts
    • packages/accounts/src/kernel-zerodev/validator/__tests__/mocks/mock-signer-validator.ts
    • packages/accounts/src/kernel-zerodev/e2e-tests/mocks/mock-signer.ts
    • packages/accounts/src/kernel-zerodev/e2e-tests/kernel-account.test.ts
    • packages/alchemy/e2e-tests/simple-account.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon merged commit 883c489 into development Nov 9, 2023
3 checks passed
@denniswon denniswon deleted the denniswon/aa_sdk_tests_fix branch November 9, 2023 22:41
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
@moldy530 moldy530 mentioned this pull request Nov 17, 2023
7 tasks
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants