feat: allow passing raw call data to sendUserOperation #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
moldy530
force-pushed
the
moldy/senduo-data-escape-hatch
branch
from
95fdef3
to
b7dc0c9
Compare
denniswon
reviewed
Nov 21, 2023
moldy530
force-pushed
the
moldy/senduo-data-escape-hatch
branch
from
b7dc0c9
to
eb94a54
Compare
|
@denniswon docs are updated |
avasisht23
reviewed
Nov 21, 2023
Comment on lines
+4
to
+9
| export type KernelUserOperationCallData = Exclude< | ||
| UserOperationCallData, | ||
| Hex | ||
| > & { | ||
| delegateCall?: boolean; | ||
| } | ||
| }; |
There was a problem hiding this comment.
oh so does Exclude only work when UserOperationCallData is the Hex type alias, vs. the calldata object of target, data, value?
There was a problem hiding this comment.
Other way around, the use of Exclude here means take all the union types of UserOperationCallData and omit the Hex one. Essentially: Exclude<a | b, b> = a
avasisht23
reviewed
Nov 21, 2023
| ### `UserOperationCallData | UserOperationCallData[]` | ||
| ### `UserOperationCallData | UserOperationCallData[] | Hex` | ||
|
|
||
| `UserOperationCallData` is an object with the following properties: |
There was a problem hiding this comment.
Suggested change
| `UserOperationCallData` is an object with the following properties: | |
| `UserOperationCallData` is either a `Hex`value, or an object with the following properties: |
There was a problem hiding this comment.
Ah, I didn't want to confuse that here actually... I add the | Hex explicitly already above to make that clearer. because otherwise it might be the case that you can do Hex[] as batch (which is not the case)
moldy530
added a commit
that referenced
this pull request
Dec 1, 2023
moldy530
added a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, see guidleines below)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:fix)developmentand notmain?PR-Codex overview
Focus of the PR:
This PR focuses on modifying the
UserOperationCallDatatype to allow for an additional propertyHex, and updating related code to accommodate this change.Detailed summary:
UserOperationCallDatatype to include an additional propertyHexKernelUserOperationCallDatatype to excludeHexKernelBatchUserOperationCallDatatype to excludeHexBatchUserOperationCallDatatype to excludeHexsendUserOperation.mdguide to includeHexas a possible parameter type