-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation for smart account provider fee options and overrides #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you thought about instead making a type glossary? can do this per package: https://viem.sh/docs/glossary/types.html
right now, these might be too much info around types. additionally, this sets a precedent that we should include docs on each type, which I think bloats our documentation a bit too much for my liking.
most of these types X have an "ifX()" method. Maybe we document those instead?
e7a8761
to
15ecb38
Compare
9048fcb
to
f06f1c5
Compare
70eec7b
to
f1906a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a comment or two but LGTM otherwise
f1906a2
to
531dab5
Compare
|
…errides (#277) * feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core * docs: add documentation for smart account provider fee options and overrides * docs: add glossary section and add general types doc in the section
…errides (#277) * feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core * docs: add documentation for smart account provider fee options and overrides * docs: add glossary section and add general types doc in the section
…errides (#277) * feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core * docs: add documentation for smart account provider fee options and overrides * docs: add glossary section and add general types doc in the section
PR-Codex overview
This PR focuses on updating the
BytesLike
type intypes.ts
and updating theoverrides
parameter in multiple files to include additional options.Detailed summary
BytesLike
type intypes.ts
to includeHex
type.overrides
parameter in multiple files to includecallGasLimit
,preVerificationGas
, andverificationGasLimit
options.