feat: add fireblocks to aa-signers #301
Conversation
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
is this necessary? can't we just hardcode this value?
There was a problem hiding this comment.
instantiating a FireblocksWeb3Provider requires the privateKey which actually does check for a file. if i just put a value for the private key itself, I get:
to avoid mocking instantiation, making a file was the easiest solution.
|
|
||
| You can either pass in a constructed `FireblocksWeb3Provider` object, or directly pass into the `FireblocksSigner` the `FireblocksProviderConfig` used to construct a `FireblocksWeb3Provider` object. These parameters are listed on the [Fireblocks repo](https://github.com/fireblocks/fireblocks-web3-provider/blob/main/src/types.ts#L48) as well. | ||
|
|
||
| `FireblocksProviderConfig` takes in the following parameters: |
There was a problem hiding this comment.
oh oof... this is gonna be a pain to have to do and maintain for each signer provider in the future. I can see the devex benefit of having this here, but once it goes out of sync it causes more harm than good. can we link out to their types or docs instead?
There was a problem hiding this comment.
yeah where possible. some SDKs don't expose this, so I have to copy-paste onto the types.ts file for the Signer (so we'll still be out of sink).
but yeah, will just link to code where possible. (saves me time too 🙏 )
avasisht23
force-pushed
the
12-03-docs_reorganize_the_sidebar
branch
from
556b416
to
2a567a4
Compare
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
8ee5ca3
to
dee199a
Compare
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
dee199a
to
ccdca68
Compare
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
ccdca68
to
e55a747
Compare
|
might need to rebase again and then I can approve |
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
f369f33
to
6f369aa
Compare
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
Focus of this PR:
This PR focuses on adding the FireblocksSigner to the project and providing methods for authentication, getting addresses, signing messages, and signing typed data.
Detailed summary:
mock-private-key.txtin thepackages/signers/src/fireblocks/__tests__/directory.export { FireblocksSigner }andexport type *topackages/signers/src/fireblocks/index.ts.import type { Address }and interfacesFireblocksAuthenticationParamsandFireblocksUserInfotopackages/signers/src/fireblocks/types.ts.FireblocksSignerandtype FireblocksAuthenticationParamstopackages/signers/src/index.ts."@fireblocks/fireblocks-web3-provider": "^1.2.6"topackages/signers/package.json.site/.vitepress/config.tsfile.getAddress.md,signMessage.md,getAuthDetails.md,authenticate.md, andsignTypedData.mdfiles tosite/packages/aa-signers/fireblocks/.fireblocks.tsin thesite/snippets/directory.import { FireblocksSigner }andimport { ChainId }tosite/snippets/fireblocks.ts.createFireblocksSignerfunction tosite/snippets/fireblocks.ts.FireblocksSignerclass topackages/signers/src/fireblocks/signer.ts.