feat: add capsule to aa-signers #305

avasisht23 · 2023-12-05T05:51:20Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR adds the CapsuleSigner to the aa-signers package. Notable changes include:

Exporting CapsuleSigner and related types from packages/signers/src/capsule/index.ts
Adding documentation for the getAddress, signMessage, getAuthDetails, and authenticate methods of CapsuleSigner
Updating the createCapsuleSigner function in site/snippets/capsule.ts to include authentication

The following files were skipped due to too many changes: site/packages/aa-signers/capsule/signTypedData.md, packages/signers/src/capsule/signer.ts, site/packages/aa-signers/capsule/introduction.md, packages/signers/src/capsule/__tests__/signer.test.ts, site/packages/aa-signers/capsule/constructor.md, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

avasisht23 · 2023-12-05T05:51:35Z

Current dependencies on/for this PR:

main
- PR docs: reorganize the sidebar #300
  - PR feat: add fireblocks to aa-signers #301
    - PR feat: add particle to aa-signers #304
      - PR feat: add capsule to aa-signers #305 👈
    - PR feat: add portal to aa-signers #303

This stack of pull requests is managed by Graphite.

packages/signers/src/capsule/__tests__/signer.test.ts

avasisht23 · 2023-12-05T06:22:54Z

packages/signers/src/capsule/types.ts

+import type { Environment } from "@usecapsule/web-sdk";
+import type { WalletClientConfig } from "viem";
+
+// copied since Capsule doesn't export this type


@nityas is there a way for Capsule to export these types from the capsule sdk so we don't have to re-write them here?

you could do something like Params<typeof Capsule.prototype.constructor> or w/e class you need the constructor params of

I'll export these types in the new version as well

packages/signers/src/capsule/__tests__/signer.test.ts

site/packages/aa-signers/capsule/constructor.md

moldy530

LGTM weird about those type issues though :/

packages/signers/src/capsule/__tests__/signer.test.ts

nsquare3 · 2023-12-11T18:53:16Z

packages/signers/src/capsule/types.ts

+import type { Environment } from "@usecapsule/web-sdk";
+import type { WalletClientConfig } from "viem";
+
+// copied since Capsule doesn't export this type


I'll export these types in the new version as well

site/packages/aa-signers/capsule/constructor.md

site/packages/aa-signers/capsule/introduction.md

The base branch was changed.

nsquare3

Just 2 comments. The main one is about authenticating a user

packages/signers/src/capsule/signer.ts

site/snippets/capsule.ts

This reverts commit 57da58d.

This reverts commit 33b1cb5.

nsquare3

approved

avasisht23 requested review from moldy530, rthomare, dancoombs, mokok123 and denniswon as code owners December 5, 2023 05:51

This was referenced Dec 5, 2023

docs: reorganize the sidebar #300

Merged

feat: add fireblocks to aa-signers #301

Merged

feat: add portal to aa-signers #303

Merged

feat: add particle to aa-signers #304

Merged

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from 5215c45 to 805c410 Compare December 5, 2023 06:02

avasisht23 commented Dec 5, 2023

View reviewed changes

packages/signers/src/capsule/__tests__/signer.test.ts Show resolved Hide resolved

avasisht23 commented Dec 5, 2023

View reviewed changes

packages/signers/src/capsule/__tests__/signer.test.ts Show resolved Hide resolved

avasisht23 commented Dec 5, 2023

View reviewed changes

moldy530 reviewed Dec 5, 2023

View reviewed changes

packages/signers/src/capsule/__tests__/signer.test.ts Show resolved Hide resolved

moldy530 reviewed Dec 5, 2023

View reviewed changes

site/packages/aa-signers/capsule/constructor.md Outdated Show resolved Hide resolved

moldy530 previously approved these changes Dec 5, 2023

View reviewed changes

avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from a540b82 to cb6ddd1 Compare December 7, 2023 22:18

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from 805c410 to 42bbb8d Compare December 7, 2023 22:18

avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from cb6ddd1 to d6c462d Compare December 11, 2023 18:31

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from 42bbb8d to fa6d3f6 Compare December 11, 2023 18:31

nsquare3 reviewed Dec 11, 2023

View reviewed changes

avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from d6c462d to cc37ab8 Compare December 11, 2023 19:54

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from fa6d3f6 to c0a9808 Compare December 11, 2023 19:54

avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from cc37ab8 to 194682e Compare December 11, 2023 20:05

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch 2 times, most recently from 3697353 to a0a3668 Compare December 11, 2023 20:13

Base automatically changed from 12-04-feat_add_particle_to_aa-signers to main December 11, 2023 20:35

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from a0a3668 to f53c7f2 Compare December 11, 2023 20:38

nsquare3 reviewed Dec 11, 2023

View reviewed changes

packages/signers/src/capsule/signer.ts Show resolved Hide resolved

site/snippets/capsule.ts Outdated Show resolved Hide resolved

avasisht23 added 5 commits December 11, 2023 19:56

feat: add capsule to aa-signers

20b8b1d

feat: add capsule to aa-signers

8d990a4

docs: update constructor on capsule feedback

65c0154

docs: update snippet per pr comment

684b68a

feat: update requirements for capsule signer

33b1cb5

avasisht23 force-pushed the 12-04-feat_add_capsule_to_aa-signers branch from 0e7efcc to 33b1cb5 Compare December 12, 2023 00:58

avasisht23 and others added 4 commits December 11, 2023 19:59

docs: update docs

57da58d

Revert "docs: update docs"

4ce7c69

This reverts commit 57da58d.

Revert "feat: update requirements for capsule signer"

f3920e6

This reverts commit 33b1cb5.

docs: include comment for creating and logging user in

b6f7c67

nsquare3 reviewed Dec 12, 2023

View reviewed changes

moldy530 approved these changes Dec 12, 2023

View reviewed changes

avasisht23 merged commit 9d89e99 into main Dec 12, 2023
2 checks passed

avasisht23 deleted the 12-04-feat_add_capsule_to_aa-signers branch December 12, 2023 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add capsule to aa-signers #305

feat: add capsule to aa-signers #305

avasisht23 commented Dec 5, 2023 •

edited by pr-codex bot

avasisht23 commented Dec 5, 2023

avasisht23 Dec 5, 2023

moldy530 Dec 5, 2023

nsquare3 Dec 11, 2023

moldy530 left a comment

nsquare3 Dec 11, 2023

nsquare3 left a comment

nsquare3 left a comment

feat: add capsule to aa-signers #305

feat: add capsule to aa-signers #305

Conversation

avasisht23 commented Dec 5, 2023 • edited by pr-codex bot

Pull Request Checklist

PR-Codex overview

avasisht23 commented Dec 5, 2023

avasisht23 Dec 5, 2023

Choose a reason for hiding this comment

moldy530 Dec 5, 2023

Choose a reason for hiding this comment

nsquare3 Dec 11, 2023

Choose a reason for hiding this comment

moldy530 left a comment

Choose a reason for hiding this comment

nsquare3 Dec 11, 2023

Choose a reason for hiding this comment

nsquare3 left a comment

Choose a reason for hiding this comment

nsquare3 left a comment

Choose a reason for hiding this comment

avasisht23 commented Dec 5, 2023 •

edited by pr-codex bot